Skip to content

ci: ignore co-author trailers in commitlint's footer length check - #22

Merged
robinbowes merged 1 commit into
mainfrom
ci/commitlint-ignore-co-author-length
Nov 11, 2026
Merged

robinbowes merged 1 commit into
mainfrom
ci/commitlint-ignore-co-author-length

Conversation

@robinbowes

Copy link
Copy Markdown

Commitlint failed on main for both release commits, v7.0.0 (aab35a7) and v7.1.0 (8008080) (e.g. run 43062767836). Squash-merging a release PR adds a Co-authored-by: semantic-release-pusher[bot] <…@users.noreply.github.com> trailer for the App that wrote the pin commit, and that line is 110 characters against footer-max-line-length's 100. PR checks lint each commit on its own, so the trailer only appears once the squash lands on main.

footer-max-line-length becomes a function rule, alongside the existing body rule, that skips Co-authored-by: lines and applies the 100-character limit to the rest of the footer.

Checked with @commitlint/load + @commitlint/lint on Node 26.13.0:

message old config new config
aab35a7 (release 7.0.0) fail pass
8008080 (release 7.1.0) fail pass
f609007, f024f3b, bfc461d — pass
120-char Co-authored-by: trailer — pass
120-char Refs: footer — fail

🤖 Generated with Claude Code

Squash-merging a release PR adds a Co-authored-by trailer for the App
that wrote its pin commit. The App's noreply address makes that line
110 characters, so commitlint failed on main for both release commits
(v7.0.0 and v7.1.0). PR checks lint each commit separately and never
see the trailer.

footer-max-line-length becomes a function rule, like the body rule
beside it, that skips Co-authored-by lines and still fails any other
footer line over 100 characters.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@robinbowes
robinbowes merged commit 1899d57 into main Nov 11, 2026
6 checks passed
@robinbowes
robinbowes deleted the ci/commitlint-ignore-co-author-length branch November 11, 2026 17:08
robinbowes added a commit that referenced this pull request Nov 11, 2026
Adds the decision behind #22 (the footer length rule skips
Co-authored-by lines), amends the release decision with the arm64
published-image check from #21, and adds a knowledge index with how
a release is cut and what a healthy run logs.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant