Repository navigation
ci: run builds on Node 22 and fix ember-try scenarios - #155
Merged
Merged
Conversation
ember-try scenarios install the latest testem, which depends on ESM-only execa and requires Node >= 20.19, failing on Node 18. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gridstack after 12.1.2 always writes gs-x/gs-y, including for 0 positions (gridstack#3181). Compare positions numerically instead of asserting the attribute is absent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186MzSR2NGh4mQyKyDJP2QF
ember-cli 4.12 cannot build Ember 7.x. Mark these scenarios allowedToFail until the Ember upgrade lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186MzSR2NGh4mQyKyDJP2QF
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the CI compatibility updates.
No open issues 🎉
What changed in this PR
This PR addresses CI failures caused by newer test dependencies and Ember releases, without changing published addon code or dependencies.
Changes:
- Moves the shared CI image from Node 18 to Node 22.
- Updates grid position assertions to accept both omitted attributes and explicit zero values.
- Temporarily allows release, beta, and canary Ember scenarios to fail while retaining their execution.
| File | Description |
|---|---|
| tests/integration/components/grid-stack-test.js | Normalizes position attributes numerically and adds an expected assertion count. |
| tests/dummy/config/ember-try.js | Marks three Ember scenarios as allowed to fail pending the Ember upgrade. |
| screwdriver.yaml | Uses Node 22 for all jobs inheriting the shared image. |
Review effort: Balanced
kevinhinterlong
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is failing on every PR (e.g. #154) because the ember-try scenarios break before running any tests. This fixes the three separate causes.
Changes
screwdriver.yaml). ember-try installs without the lockfile and picks up the latest testem (3.21.x), which depends on ESM-onlyexecaand requires Node >= 20.19. On Node 18 every scenario crashed withERR_REQUIRE_ESM.gs-x/gs-y="0"in the grid-stack integration test. Newer gridstack 12.x always writes these attributes, including for 0 positions (gridstack#3181), while 12.1.2 (our lockfile) omits them. The test now compares positions numerically, so it passes on both.ember-release,ember-betaandember-canaryasallowedToFail. These now resolve to Ember 7.x, which ember-cli 4.12 can't build. They still run and report; remove the flag once the Ember upgrade lands.No addon code, dependencies or
engineschange, so nothing published to users is affected.Testing
Ran
yarn install --frozen-lockfile && yarn teston Node 22.23.5, both on this branch and merged with #154:ember-lts-4.4,ember-lts-4.8,embroider-safe,embroider-optimizedpass; release/beta/canary fail (allowed)The grid-stack tests also pass against gridstack 12.1.2 and 12.6.0.
Not verified locally: the
publish(semantic-release) andgh-pagesjobs, which also move to Node 22.Follow-ups
allowedToFail.engines.node, since Node 18 is no longer tested.🤖 Generated with Claude Code