Skip to content

ci: run builds on Node 22 and fix ember-try scenarios - #155

Merged
kevinhinterlong merged 3 commits into
masterfrom
ci/node-22
Nov 15, 2026
Merged

kevinhinterlong merged 3 commits into
masterfrom
ci/node-22

Conversation

@jkusa

@jkusa jkusa commented Nov 14, 2026

Copy link
Copy Markdown
Member

CI is failing on every PR (e.g. #154) because the ember-try scenarios break before running any tests. This fixes the three separate causes.

Changes

  • Run CI on Node 22 (screwdriver.yaml). ember-try installs without the lockfile and picks up the latest testem (3.21.x), which depends on ESM-only execa and requires Node >= 20.19. On Node 18 every scenario crashed with ERR_REQUIRE_ESM.
  • Accept explicit gs-x/gs-y="0" in the grid-stack integration test. Newer gridstack 12.x always writes these attributes, including for 0 positions (gridstack#3181), while 12.1.2 (our lockfile) omits them. The test now compares positions numerically, so it passes on both.
  • Mark ember-release, ember-beta and ember-canary as allowedToFail. These now resolve to Ember 7.x, which ember-cli 4.12 can't build. They still run and report; remove the flag once the Ember upgrade lands.

No addon code, dependencies or engines change, so nothing published to users is affected.

Testing

Ran yarn install --frozen-lockfile && yarn test on Node 22.23.5, both on this branch and merged with #154:

  • lint: pass
  • main run: 16 pass, 0 fail
  • ember-try: ember-lts-4.4, ember-lts-4.8, embroider-safe, embroider-optimized pass; release/beta/canary fail (allowed)

The grid-stack tests also pass against gridstack 12.1.2 and 12.6.0.

Not verified locally: the publish (semantic-release) and gh-pages jobs, which also move to Node 22.

Follow-ups

  • Upgrade to current Ember (7.x / LTS 6.12) and drop allowedToFail.
  • Consider narrowing engines.node, since Node 18 is no longer tested.

🤖 Generated with Claude Code

jkusa and others added 3 commits November 14, 2026 07:49
ember-try scenarios install the latest testem, which depends on
ESM-only execa and requires Node >= 20.19, failing on Node 18.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gridstack after 12.1.2 always writes gs-x/gs-y, including for 0
positions (gridstack#3181). Compare positions numerically instead of
asserting the attribute is absent.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0186MzSR2NGh4mQyKyDJP2QF
ember-cli 4.12 cannot build Ember 7.x. Mark these scenarios
allowedToFail until the Ember upgrade lands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0186MzSR2NGh4mQyKyDJP2QF

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the CI compatibility updates.

No open issues 🎉

What changed in this PR

This PR addresses CI failures caused by newer test dependencies and Ember releases, without changing published addon code or dependencies.

Changes:

  • Moves the shared CI image from Node 18 to Node 22.
  • Updates grid position assertions to accept both omitted attributes and explicit zero values.
  • Temporarily allows release, beta, and canary Ember scenarios to fail while retaining their execution.
File Description
tests/​integration/​components/​grid-stack-test.js Normalizes position attributes numerically and adds an expected assertion count.
tests/​dummy/​config/​ember-try.js Marks three Ember scenarios as allowed to fail pending the Ember upgrade.
screwdriver.yaml Uses Node 22 for all jobs inheriting the shared image.

Review effort: Balanced

@kevinhinterlong
kevinhinterlong merged commit 88fd0a2 into master Nov 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants