Repository navigation
Skip DataFusion datasource v1 in nightly benchmarks, and fix the nested TPC-H S3 data path - #11726
Merged
Merged
Conversation
…ed TPC-H S3 data path Nightly run 44843664966 lost six jobs to DataFusion's datasource integration on the v1 scan: TPC-DS hung on q62 until the job timed out, and the runner shut down during TPC-DS q62 and TPC-H q18. Nightly now skips that combination (`NIGHTLY_SKIP_SCANS`). The file v1 scans stay. Nested TPC-H on S3 has failed every night since #11191: prepare-data writes `tpch-nested/100/list` for `scale_factor=100`, but the upload read `tpch-nested/100.0/list`. The catalog now names the directory prepare-data writes, and a test checks that each S3 `local_dir` names the scale factor its job passes. Signed-off-by: Will Manning <will@willmanning.io>
lwwmanning
marked this pull request as ready for review
November 21, 2026 22:45
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
robert3005
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the nightly SQL benchmark matrix in
bench-orchestrator/bench_orchestrator/ci_matrix/catalog.py. The develop and PR presets are unchanged.Before, nightly ran DataFusion's datasource integration on the v1 scan for every benchmark, which #11685 added. On its first night, six of those jobs failed. TPC-DS SF=10 hung on q62 until the 120-minute job timeout, and the runner shut down during TPC-DS SF=100 q62 and TPC-H SF=100 q18. After, nightly skips datasource v1. The file v1 scans on DataFusion and DuckDB stay, because they pass. Develop and
pr-scanstill run datasource v1 on ClickBench and TPC-H SF=1.Before, Nested TPC-H on S3 failed every night since #11191. prepare-data wrote the data under
tpch-nested/100/list, but the upload readtpch-nested/100.0/list. After, the upload reads the directory that prepare-data writes. A new test checks that each S3 data path names the scale factor its job passes.🤖 Generated with Claude Code