Repository navigation
Conversation
Signed-off-by: Daniel King <dan@spiraldb.com>
Contributor
|
can we add the datafusion float equals semantics? I think spark and paimon have the same |
Contributor
Author
|
You are probably a better Codex overseer for that than me. This was just a bug fix we did along the way to fast Viceberg. are you imagining like a modes option on equality? |
Contributor
|
I need to decide if this is a mode or another expression implementation. If it's another expression implementation it's hard to mix them, if it's a mode it would be easier... let me prototype both |
Contributor
|
Full fix in #11401 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataFusion binary comparisons treat
-0.0and+0.0as equal, while Vortex comparisons distinguish them. Pushingvalue = 0.0into a Vortex scan can drop matching negative-zero rows; a residual filter cannot recover them. This also affects supported comparisons recovered from a live join filter beside an unsupported hash predicate.Changes
Decline binary comparison conversion for floating operands, including dictionary value types, and leave exact evaluation in DataFusion. Floating arithmetic and
INconversion are retained;INhas distinct bitwise semantics and existing signed-zero/NaN coverage. The dynamic conjunct recovery andfind_betweenoptimization from #11215 are unchanged.Add real Vortex DataSource regressions for static equality and a changing dynamic equality-plus-unsupported-modulo filter, both retaining a DataFusion residual and requiring both signed-zero rows.
Validation: pinned-nightly formatting and whitespace checks passed. The focused reproducer was exercised during the ColdFusion investigation; these two tests on the current upstream base have not been run locally and await CI. No throughput claim.
AI assistance: Codex investigated and prepared this patch.