Repository navigation
Conversation
v3 waits for the deployment and fails the job when the build or the deployment fails; v2 finished when the build was submitted. Both actions are pinned by commit, a concurrency group keeps deploys in order, and the token gets read-only repository permissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the deploy workflow from
valar/action@v2to v3.0.0.actions/checkoutv7.0.1, replacing@v1, andvalar/actionv3.0.0. The tag is in a comment. This follows the "Actions are pinned by SHA" decision.concurrencygroup lets one deploy finish before the next starts.permissions: contents: readfor the job token.productionenvironment whose URL is the deployed service, so the commit and its pull request link to it. GitHub creates the environment on the first run.The
VALAR_TOKENsecret and.valar.ymlstay as they are.This changes
.github, so it waits for your review. The first push to master after the merge will show whether the deploy and its wait work end to end.