Skip to content

Deploy with valar/action v3 - #6

Open
lnsp wants to merge 1 commit into
masterfrom
action-v3
Open

lnsp wants to merge 1 commit into
masterfrom
action-v3

Conversation

@lnsp

@lnsp lnsp commented Nov 20, 2026

Copy link
Copy Markdown
Member

What

Moves the deploy workflow from valar/action@v2 to v3.0.0.

  • v3 waits for the deployment. It fails the job when the build or the deployment fails, and puts the build log in the job log. v2 finished as soon as the build was submitted, so a failed build left the job green.
  • Both actions are pinned by commit: actions/checkout v7.0.1, replacing @v1, and valar/action v3.0.0. The tag is in a comment. This follows the "Actions are pinned by SHA" decision.
  • A concurrency group lets one deploy finish before the next starts.
  • permissions: contents: read for the job token.
  • A production environment whose URL is the deployed service, so the commit and its pull request link to it. GitHub creates the environment on the first run.

The VALAR_TOKEN secret and .valar.yml stay as they are.

This changes .github, so it waits for your review. The first push to master after the merge will show whether the deploy and its wait work end to end.

v3 waits for the deployment and fails the job when the build or the
deployment fails; v2 finished when the build was submitted. Both actions
are pinned by commit, a concurrency group keeps deploys in order, and the
token gets read-only repository permissions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant