Repository navigation
Show why a deployment failed and where to read its log - #27
Merged
Merged
Conversation
build push --wait reports a failed deployment with the server's failure kind and message, the version that keeps serving, and the command that reads the deployment's log. On a terminal outside CI it also prints the last 20 lines of that log, with control characters escaped. Servers without failure kinds still get their error text. deployment list marks failed deployments with their kind, and --json passes the failure object through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows why a deployment failed, using the
failureobject that newer platforms add to deployments.build push --waitfailure; a server without it gets today'serrortext (deployment of version 7 failed: <error>).donedeployment in the list the wait already fetched, so it costs no extra request.deployment=N&seek=end&skip=20) only on a terminal, outside CI (CIunset orfalse) and without--json. Control characters are escaped. Reading the log is best effort; errors are ignored.failed).deployment listWith
--json,failurepasses through unchanged and is omitted when the server sends none.Tests
Table-driven against a test HTTP server: failure present, failure absent (older server), terminal with and without
CI, and--jsonpassthrough ofdeployment list.