Repository navigation
Conversation
realTaki
marked this pull request as ready for review
November 19, 2026 23:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot #93 is useful, but a lockfile-only update covers environments that consume this repository's
uv.lock. It doesn't change what the published SDK permits: pip and other resolvers use the dependency metadata in the built distribution, not this lockfile. For example, a compatible but already-installed pyasn1 0.6.4 can still satisfy an unconstrained requirement.This PR updates both places:
pyproject.toml: requirepyasn1>=0.6.5so the wheel's install metadata excludes affected older releases.uv.lock: select pyasn1 0.6.5 and synchronize the SDK package's recorded dependency requirement.This incorporates the intent of #93 without changing unrelated packages or raising the SDK's advertised Python minimum. pyasn1 0.6.5 supports Python 3.8+.
Validation:
uv lock --checkand wheel build passed. The built wheel declaresRequires-Dist: pyasn1>=0.6.5andRequires-Python: >=3.8. No live account or trading calls were performed.