Skip to content

power_down: move IPC_HOST_BASE literal into register - #3582

Merged
lgirdwood merged 2 commits into
thesofproject:masterfrom
bkokoszx:ctx-save-timeout-fix
Nov 9, 2020
Merged

lgirdwood merged 2 commits into
thesofproject:masterfrom
bkokoszx:ctx-save-timeout-fix

Conversation

@bkokoszx

@bkokoszx bkokoszx commented Nov 4, 2020

Copy link
Copy Markdown
Collaborator

Before switching off memory, IPC_HOST_BASE literal value should
be moved to register, in order to avoid accessing to disabled
memory.

fixes #3538

Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com

@keyonjie

keyonjie commented Nov 5, 2020

Copy link
Copy Markdown
Contributor

Good finding @bkokoszx !

So do we need similar fix to apollolake/lib/power_down.S also?

And, do you think the CI CML_MANTIS_HDA failure could be related?

@bkokoszx

bkokoszx commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator Author

Thanks for @mmaka1 in debugging process.

Yes, I think we need similar change for APL. I will add this change.

I do not suspect that CI failure is related. I can try to retrigger CI.

Before switching off memory, IPC_HOST_BASE literal value should
be moved to register, in order to avoid accessing to disabled
memory.

Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
Before switching off memory, IPC_HOST_BASE literal value should
be moved to register, in order to avoid accessing to disabled
memory.

Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
@bkokoszx
bkokoszx force-pushed the ctx-save-timeout-fix branch from a00934b to 3373ba7 Compare November 5, 2020 09:16
@bkokoszx

bkokoszx commented Nov 5, 2020 •

Copy link
Copy Markdown
Collaborator Author

@keyonjie
I've just added APL part also.

@bkokoszx

bkokoszx commented Nov 6, 2020

Copy link
Copy Markdown
Collaborator Author

@keyonjie
It looks like CI passes.

@lgirdwood
lgirdwood merged commit c66d5b5 into thesofproject:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][TGL] [DSM] [I2S] ctx_save ipc time out and errors are observed while speaker playback stop

3 participants