Repository navigation
power_down: move IPC_HOST_BASE literal into register - #3582
Merged
Merged
Conversation
bkokoszx
requested review from
dbaluta,
jajanusz,
lbetlej,
lgirdwood and
plbossart
as code owners
November 4, 2020 10:17
Contributor
|
Good finding @bkokoszx ! So do we need similar fix to apollolake/lib/power_down.S also? And, do you think the CI CML_MANTIS_HDA failure could be related? |
Collaborator
Author
|
Thanks for @mmaka1 in debugging process. Yes, I think we need similar change for APL. I will add this change. I do not suspect that CI failure is related. I can try to retrigger CI. |
Before switching off memory, IPC_HOST_BASE literal value should be moved to register, in order to avoid accessing to disabled memory. Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
Before switching off memory, IPC_HOST_BASE literal value should be moved to register, in order to avoid accessing to disabled memory. Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
bkokoszx
force-pushed
the
ctx-save-timeout-fix
branch
from
November 5, 2020 09:16
a00934b to
3373ba7
Compare
Collaborator
Author
|
@keyonjie |
Collaborator
Author
|
@keyonjie |
lgirdwood
approved these changes
Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before switching off memory, IPC_HOST_BASE literal value should
be moved to register, in order to avoid accessing to disabled
memory.
fixes #3538
Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com