Skip to content

topology:sof-byt-rt5651: add virtual widgets for machine driver compa… - #1108

Merged
lgirdwood merged 1 commit into
thesofproject:masterfrom
ranj063:fix/byt_failure
Mar 11, 2019
Merged

lgirdwood merged 1 commit into
thesofproject:masterfrom
ranj063:fix/byt_failure

Conversation

@ranj063

@ranj063 ranj063 commented Mar 10, 2019

Copy link
Copy Markdown
Collaborator

…tibitlity

Add virtual widgets for ssp2 RX/TX for compatibility with the
bytcr_rt5651 machine driver. This is needed now because a recent
change in the driver removed these from the dai definitions
which results in card registration failure.

Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com

…tibitlity

Add virtual widgets for ssp2 RX/TX for compatibility with the
bytcr_rt5651 machine driver. This is needed now because a recent
change in the driver removed these from the dai definitions
which results in card registration failure.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@bardliao

Copy link
Copy Markdown
Collaborator

Add virtual widgets for ssp2 RX/TX for compatibility with the
bytcr_rt5651 machine driver. This is needed now because a recent
change in the driver removed these from the dai definitions
which results in card registration failure.

@ranj063 Could you point out which patch remove ssp2 RX/TX?
If ssp2 RX/TX is no longer exist, I think we should remove them from machine driver, too.
If they are still used by sst driver, we will need to add virtual widget to all byt topologys.

@lgirdwood
lgirdwood merged commit 93c130a into thesofproject:master Mar 11, 2019
@lgirdwood

Copy link
Copy Markdown
Member

@bardliao Iirc, the BYT-CR machine drivers used ssp2 RX/TX, but the BYT machine drivers did not. Best to check. Fwiw, the BYT-CR driver are now the preferred driver since they also support BYT.

@ranj063

ranj063 commented Mar 11, 2019

Copy link
Copy Markdown
Collaborator Author

@bardliao yes the byt-cr machine use them. And yes, we might need to add them to the rt5640 as well. @juimonen not sure if you have a BYT with rt5640. Can you please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants