You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[BUG] DAI types diverged between Zephyr and Linux kernel #9803
I'm trying to add a new type zephyrproject-rtos/zephyr@4411719 in Zephyr, but because this struct diverged I'm having trouble in probing the DAI driver.
Hmm. @dbaluta I remember discusion about this is some SOF PR that these two enums should not be mixed as there's no guarantees for the two to stay in sync. I remember this been discussed in changed in base_fw_intel.com, but I wonder now whether we have missed some bigger miuse of the dai types. I think in SOF FW, there should be a translation between Zephyr DAI type and SOF IPC DAI type.
Ack, sof/src/lib/dai.c:dai_get() is mixing SOF and Zephyr DAI types. It should do a look-up for DAI-types from IPC definition to Zephyr DAI interface.
This went unnoticed when SOF_DAI_AMD_HS et al were added as these platforms did not have Zephyr support back then.
It would seem existing DAI types used by SOF Zephyr configurations all work currnetly, but it's no impossible to add new definitions unless a translation layer is added to dai_get().
Activity
dbaluta commentedon Jan 29, 2025
@lgirdwood am I missing something about this?
I'm trying to add a new type zephyrproject-rtos/zephyr@4411719 in Zephyr, but because this struct diverged I'm having trouble in probing the DAI driver.
kv2019i commentedon Feb 3, 2025
Hmm. @dbaluta I remember discusion about this is some SOF PR that these two enums should not be mixed as there's no guarantees for the two to stay in sync. I remember this been discussed in changed in base_fw_intel.com, but I wonder now whether we have missed some bigger miuse of the dai types. I think in SOF FW, there should be a translation between Zephyr DAI type and SOF IPC DAI type.
kv2019i commentedon Feb 3, 2025
Ack, sof/src/lib/dai.c:dai_get() is mixing SOF and Zephyr DAI types. It should do a look-up for DAI-types from IPC definition to Zephyr DAI interface.
This went unnoticed when SOF_DAI_AMD_HS et al were added as these platforms did not have Zephyr support back then.
It would seem existing DAI types used by SOF Zephyr configurations all work currnetly, but it's no impossible to add new definitions unless a translation layer is added to dai_get().
dbaluta commentedon Feb 3, 2025
@kv2019i Added this PR #9807