Skip to content

[FEATURE] show WARN_ON() results #774

Open

Description

@plbossart

Is your feature request related to a problem? Please describe.

So far sof-test only reports the errors. It would be useful to show this type of warnings, which clearly point to something very wrong.

[  562.418115] kernel: WARNING: lock held when returning to user space!
[  562.418117] kernel: 5.15.0-rc1-pr3186-6452-nocodec #6d37c52e Not tainted
[  562.418120] kernel: ------------------------------------------------
[  562.418122] kernel: aplay/8747 is leaving the kernel with locks still held!
[  562.418125] kernel: 1 lock held by aplay/8747:
[  562.418127] kernel:  #0: ffffffffc07673e0 (&card->dpcm_mutex){....}-{3:3}, at: dpcm_be_dai_trigger+0x3da/0x4d0 [snd_soc_core]

Describe the solution you'd like

these lines shown in the output of sof-test scripts and an error status. Maybe in some cases we'll see false positives but we can filter them out

Describe alternatives you've considered
stop on warnings would be too invasive?

Activity

  1. marc-hb commented on Oct 1, 2021

    @marc-hb
    Contributor

    One problem is neither github nor Jenkins (nor Travis) supports any intermediate "warning" level. It's either PASS or FAIL and nothing available in between. Binary like cable news and social media.

    Right now success is based on journalctl -k --priority=err. We can certainly run journalctl -k --priority=warn too but then what do we do with the output? In which place(s) would like this to be displayed and how?

  2. plbossart commented on Oct 1, 2021

    @plbossart
    MemberAuthor

    well that's precisely why I asked, I don't know how to do it.
    if we report all the warnings we'll fail all the time. maybe filter and only allow the warnings when we see a pattern of WARNING with a kernel version below and the ---- delimiter.

  3. added
    type:bugSomething doesn't work as expected
    P2Critical bugs or normal features
    area:logsLog and results collection, storage, etc.
    on Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    False Pass / green failureP2Critical bugs or normal featuresarea:logsLog and results collection, storage, etc.type:bugSomething doesn't work as expected

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions