Skip to content

ASoC: dapm: remove power_check callback for src/asrc widgets - #706

Closed
ranj063 wants to merge 1 commit into
thesofproject:topic/sof-devfrom
ranj063:fix/power_check
Closed

ranj063 wants to merge 1 commit into
thesofproject:topic/sof-devfrom
ranj063:fix/power_check

Conversation

@ranj063

@ranj063 ranj063 commented Mar 10, 2019

Copy link
Copy Markdown
Collaborator

The recently added commit(0a36bd4) to set the power_check callback for
src/asrc type widgets causes hw_params failure with the RT5651
codec. So revert this change.

Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com

@plbossart

Copy link
Copy Markdown
Member

Sorry, I don't buy this. I don't understand how this patch impacts the rt5651 and no other codec, and on top of this if we remove the effects as well isn't this going to impact the hotword solution?

The recently added commit(0a36bd4) to set the power_check callback for
src/asrc type widgets causes hw_params failure with the RT5651
codec. So revert this change.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063

ranj063 commented Mar 10, 2019 •

Copy link
Copy Markdown
Collaborator Author

Sorry, I don't buy this. I don't understand how this patch impacts the rt5651 and no other codec, and on top of this if we remove the effects as well isn't this going to impact the hotword solution?

@plbossart oops sorry. I only meant to remove the src/asrc. But I'm attaching the dapm graph here for further discussion. There are 2 ASRC widgets in the graph. I am not sure what the connection is. @bardliao we're going to need your help here.

I cant say for sure that it doesnt affect any other codec. I'll have to check the other realtek codecs to confirm. Bard, do you have the BYT with RT5640?

widgets

@ranj063

ranj063 commented Mar 11, 2019

Copy link
Copy Markdown
Collaborator Author

@plbossart this may not be related to the codec after all. Just realised after talking tp Bard that the sof-byt-rt5651 tplg uses an src in its pipeline.

@juimonen

Copy link
Copy Markdown

@juimonen I get a lot of hwparams errors (timeouts) with nocodec topology also

@juimonen

Copy link
Copy Markdown

heh informing myself, but was meant to @ranj063 :)

@bardliao

Copy link
Copy Markdown
Collaborator

@ranj063 @plbossart It looks more like a platform related issue. I can also "fix" it by removing snd_soc_dapm_pga and keeping snd_soc_dapm_src/asrc. Look like we won't see this issue if we have at least one dapm widget on before playback. It seems the irq is disabled for some reason, but I don't know when and why it is disabled yet.

@juimonen

Copy link
Copy Markdown

tested this with minnow and nocodec-topology andthis patch really fixes the errors.

@bardliao

Copy link
Copy Markdown
Collaborator

Another finding is that when I check power_status after boot up, it will show D3hot on the abnormal case and D0 on the normal case.
eg. cat /sys/bus/acpi/devices/80860F28:01/power_state on minnow.
Besides, we will meet the ipc timed out issue if we try to set amixer on D3hot.
In other words, we can hit the issue without playback.

@plbossart

Copy link
Copy Markdown
Member

i wonder if the rt5651/40 support can work without the .pm_ops set at the card level?

@ranj063

ranj063 commented Mar 11, 2019

Copy link
Copy Markdown
Collaborator Author

@juimonen yes, this patch fixes the hw_params because it prevents the DSP from being powered off. However, this isnt the right solution. We need to implement pm ops for BYT or find a way to disable PM on BYT until the callback are implemented.

@ranj063

ranj063 commented Mar 11, 2019

Copy link
Copy Markdown
Collaborator Author

closing this one as #708 is a better workaround to prevent the DSP power off for ACPI devices

@ranj063 ranj063 closed this Mar 11, 2019
@ranj063
ranj063 deleted the fix/power_check branch March 22, 2019 17:05
oder-chiou pushed a commit to oder-chiou/linux-soundwire that referenced this pull request May 5, 2026
bioset acct is only needed for raid0 and raid5. Therefore, md_run only
allocates it for raid0 and raid5. However, this does not cover
personality takeover, which may cause uninitialized bioset. For example,
the following repro steps:

  mdadm -CR /dev/md0 -l1 -n2 /dev/loop0 /dev/loop1
  mdadm --wait /dev/md0
  mkfs.xfs /dev/md0
  mdadm /dev/md0 --grow -l5
  mount /dev/md0 /mnt

causes panic like:

[  225.933939] BUG: kernel NULL pointer dereference, address: 0000000000000000
[  225.934903] #PF: supervisor instruction fetch in kernel mode
[  225.935639] #PF: error_code(0x0010) - not-present page
[  225.936361] PGD 0 P4D 0
[  225.936677] Oops: 0010 [thesofproject#1] PREEMPT SMP DEBUG_PAGEALLOC KASAN PTI
[  225.937525] CPU: 27 PID: 1133 Comm: mount Not tainted 5.16.0-rc3+ thesofproject#706
[  225.938416] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-2.module_el8.4.0+547+a85d02ba 04/01/2014
[  225.939922] RIP: 0010:0x0
[  225.940289] Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6.
[  225.941196] RSP: 0018:ffff88815897eff0 EFLAGS: 00010246
[  225.941897] RAX: 0000000000000000 RBX: 0000000000092800 RCX: ffffffff81370a39
[  225.942813] RDX: dffffc0000000000 RSI: 0000000000000000 RDI: 0000000000092800
[  225.943772] RBP: 1ffff1102b12fe04 R08: fffffbfff0b43c01 R09: fffffbfff0b43c01
[  225.944807] R10: ffffffff85a1e007 R11: fffffbfff0b43c00 R12: ffff88810eaaaf58
[  225.945757] R13: 0000000000000000 R14: ffff88810eaaafb8 R15: ffff88815897f040
[  225.946709] FS:  00007ff3f2505080(0000) GS:ffff888fb5e00000(0000) knlGS:0000000000000000
[  225.947814] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  225.948556] CR2: ffffffffffffffd6 CR3: 000000015aa5a006 CR4: 0000000000370ee0
[  225.949537] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[  225.950455] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[  225.951414] Call Trace:
[  225.951787]  <TASK>
[  225.952120]  mempool_alloc+0xe5/0x250
[  225.952625]  ? mempool_resize+0x370/0x370
[  225.953187]  ? rcu_read_lock_sched_held+0xa1/0xd0
[  225.953862]  ? rcu_read_lock_bh_held+0xb0/0xb0
[  225.954464]  ? sched_clock_cpu+0x15/0x120
[  225.955019]  ? find_held_lock+0xac/0xd0
[  225.955564]  bio_alloc_bioset+0x1ed/0x2a0
[  225.956080]  ? lock_downgrade+0x3a0/0x3a0
[  225.956644]  ? bvec_alloc+0xc0/0xc0
[  225.957135]  bio_clone_fast+0x19/0x80
[  225.957651]  raid5_make_request+0x1370/0x1b70
[  225.958286]  ? sched_clock_cpu+0x15/0x120
[  225.958797]  ? __lock_acquire+0x8b2/0x3510
[  225.959339]  ? raid5_get_active_stripe+0xce0/0xce0
[  225.959986]  ? lock_is_held_type+0xd8/0x130
[  225.960528]  ? rcu_read_lock_sched_held+0xa1/0xd0
[  225.961135]  ? rcu_read_lock_bh_held+0xb0/0xb0
[  225.961703]  ? sched_clock_cpu+0x15/0x120
[  225.962232]  ? lock_release+0x27a/0x6c0
[  225.962746]  ? do_wait_intr_irq+0x130/0x130
[  225.963302]  ? lock_downgrade+0x3a0/0x3a0
[  225.963815]  ? lock_release+0x6c0/0x6c0
[  225.964348]  md_handle_request+0x342/0x530
[  225.964888]  ? set_in_sync+0x170/0x170
[  225.965397]  ? blk_queue_split+0x133/0x150
[  225.965988]  ? __blk_queue_split+0x8b0/0x8b0
[  225.966524]  ? submit_bio_checks+0x3b2/0x9d0
[  225.967069]  md_submit_bio+0x127/0x1c0
[...]

Fix this by moving alloc/free of acct bioset to pers->run and pers->free.

While we are on this, properly handle md_integrity_register() error in
raid0_run().

Fixes: daee202 (md: check level before create and exit io_acct_set)
Cc: stable@vger.kernel.org
Acked-by: Guoqing Jiang <guoqing.jiang@linux.dev>
Signed-off-by: Xiao Ni <xni@redhat.com>
Signed-off-by: Song Liu <song@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants