Repository navigation
DAPM graph fixes and clean ups #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8129aec
f147f56
a044708
ca43cb6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3651,6 +3651,13 @@ snd_soc_dapm_new_control_unlocked(struct snd_soc_dapm_context *dapm, | |
| case snd_soc_dapm_dac: | ||
| case snd_soc_dapm_aif_in: | ||
| case snd_soc_dapm_pga: | ||
| case snd_soc_dapm_buffer: | ||
| case snd_soc_dapm_scheduler: | ||
| case snd_soc_dapm_effect: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Meh. this isn't the same order as definitions and it's missing asrc/encoder/decoder. |
||
| case snd_soc_dapm_src: | ||
| case snd_soc_dapm_asrc: | ||
| case snd_soc_dapm_encoder: | ||
| case snd_soc_dapm_decoder: | ||
| case snd_soc_dapm_out_drv: | ||
| case snd_soc_dapm_micbias: | ||
| case snd_soc_dapm_line: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -640,24 +640,13 @@ static int bdw_probe(struct snd_sof_dev *sdev) | |
| return ret; | ||
| } | ||
|
|
||
| #define BDW_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE | \ | ||
| SNDRV_PCM_FMTBIT_S32_LE) | ||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these formats may not be used, but at the same time we currently have restrictions on what the topology can do (single format per DAI), and there will be no check that the topology settings are correct and supported by the firmware. We should probably have a layer that does check the topology is indeed supported, otherwise with a single error in a topology file we have a risk of reaching unsupported configurations. it's just too risky.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @plbossart makes sense. I can add the check but looking at the formats defined for all platforms, I see no restrictions. All platforms seem to support 16/24/32 bit formats. Is that a mistake? If it is, could you please remind me what they should look like? |
||
| /* Broadwell DAIs */ | ||
| static struct snd_soc_dai_driver bdw_dai[] = { | ||
| { | ||
| .name = "ssp0-port", | ||
| .playback = SOF_DAI_STREAM("ssp0 Tx", 1, 8, | ||
| SNDRV_PCM_RATE_8000_192000, BDW_FORMATS), | ||
| .capture = SOF_DAI_STREAM("ssp0 Rx", 1, 8, | ||
| SNDRV_PCM_RATE_8000_192000, BDW_FORMATS), | ||
| }, | ||
| { | ||
| .name = "ssp1-port", | ||
| .playback = SOF_DAI_STREAM("ssp1 Tx", 1, 8, | ||
| SNDRV_PCM_RATE_8000_192000, BDW_FORMATS), | ||
| .capture = SOF_DAI_STREAM("ssp1 Rx", 1, 8, | ||
| SNDRV_PCM_RATE_8000_192000, BDW_FORMATS), | ||
| }, | ||
| }; | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about all the effects/src/asrc that were added at the same time as buffer/scheduler? Should they really be always on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@plbossart no, added them too now.