Repository navigation
ASoC: rt722-sdca: Enable speaker playback on Acer Swift Pro SFP14-55 - #6052
shripad-jyothinath wants to merge 1 commit into
Conversation
The internal speakers on the Acer Swift Pro SFP14-55 (Meteor Lake-P with Realtek RT722 SDCA SoundWire codec) produce no sound on Linux. Investigation revealed several factors preventing audio output: 1. In the ACPI SSDT table, the Class-D SmartAmp power domain is declared under Entity 0x41 (Device E041), but the upstream rt722 header hardcodes RT722_SDCA_ENT_PDE23 as 0x23. Update the definition to 0x41. 2. Hardware register 0x61:0x29 (RT722_AMP_PDE_FLOAT_CTL) controls which entity the Class-D power domain is mapped to. The default is 0x2323. On Acer SFP14-55, set this to 0x4141 to map it to Entity 0x41. 3. Hardware register 0x20:0x07 (RT722_MISC_CTRL1) bit 15 (0x8000) must be set to route digital stream audio to the Class-D stage. When this bit is clear, audio from the bus is blocked at the bridge. 4. Apply the ACPI AF04 FIT Class-D tuning values (0x20:0x38 = 0x890a, 0x20:0x37 = 0xfc15, 0x20:0x40 = 0x8800). 5. On stream start (POST_PMU), power up the amplifier PLL and LDOs (0x5F:0x0B = 0x9800) and raise EAPD (0x20:0x10 = 0x0360) with an 80ms settling delay to avoid pops. On stream stop (PRE_PMD), lower EAPD to 0x0260 and cut amplifier power back to 0x0000. Add a DMI quirk table matching the Acer Swift Pro SFP14-55 to apply these settings cleanly without affecting other platforms. Signed-off-by: Shripad J <shripad-jyothinath@users.noreply.github.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Can one of the admins verify this patch?
|
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This patch enables the internal stereo speakers on the Acer Swift Pro SFP14-55 (Meteor Lake-P with Realtek RT722 SDCA SoundWire codec).
Problem
On the Acer Swift Pro SFP14-55, audio output through the internal speakers produces no sound at all under Linux, even though headphones and DMIC work fine.
Root Cause
While debugging on the actual laptop hardware and comparing ACPI SSDT tables against the SoundWire register dumps, I found a few key issues preventing the Class-D amplifier from producing sound:
Device (E041)), butRT722_SDCA_ENT_PDE23inrt722-sdca.hwas hardcoded to0x23.0x61:0x29(RT722_AMP_PDE_FLOAT_CTL) defaults to0x2323, which leaves the amplifier power domain disconnected from Entity 0x41. Setting this to0x4141connects it to the power domain declared in ACPI.0x20:0x07(RT722_MISC_CTRL1) bit 15 (0x8000) was unasserted by default. Without setting bit 15, digital audio stream data from the SoundWire bus is gated and does not reach the Class-D stage.0x20:0x38 = 0x890a,0x20:0x37 = 0xfc15,0x20:0x40 = 0x8800).0x5F:0x0Bneed to be enabled (0x9800) along with raising EAPD (0x20:0x10 = 0x0360) duringSND_SOC_DAPM_POST_PMU. An 80ms settling delay avoids DC pop. On stream stop (PRE_PMD), EAPD is lowered back to0x0260and the amp power is cut.Changes
RT722_QUIRK_ACER_SFP14_55).rt722_sdca_init().rt722_sdca_spk_event().RT722_SDCA_ENT_PDE23define to0x41.Verification
pw-play).