Repository navigation
Revert fwnode changes and add description of fwnode cases - #2655
Conversation
|
@andy-shev Could you review this PR? |
andy-shev
left a comment
There was a problem hiding this comment.
Commit message is unclear. Can you rephrase it, like "While the commit SHA ("DESCRIPTION") describes everything correct in its commit message the change it made does the opposite and original commit SHA ("DESCRIPTION") was fully correct. Thus, revert the former one here and improve documentation in the next patch". Also it misses Fixes tag.
andy-shev
left a comment
There was a problem hiding this comment.
add spaces and one dash in the list, so it will be ' --> ' to avoid potential confusion with C pointers.
d9490d8 to
b6e5fa2
Compare
|
Thanks @andy-shev PR updated. |
| dev->fwnode = fn->secondary; | ||
| if (!(parent && fn == parent->fwnode)) | ||
| fn->secondary = ERR_PTR(-ENODEV); | ||
| fn->secondary = NULL; |
There was a problem hiding this comment.
I think by "original commit SHA ("DESCRIPTION") was fully correct" something different was meant, I think @andy-shev was asking to mention the original commit that introduced the code before d5dcce0
There was a problem hiding this comment.
I think by "original commit SHA ("DESCRIPTION") was fully correct" something different was meant, I think @andy-shev was asking to mention the original commit that introduced the code before d5dcce0
Thanks @lyakh for pointing it out.
While the commit d5dcce0 ("device property: Keep secondary firmware node secondary by type") describes everything correct in its commit message the change it made does the opposite and original commit c15e1bd ("device property: Fix the secondary firmware node handling in set_primary_fwnode()") was fully correct. Thus, revert the former one here and improve documentation in the next patch. Fixes: d5dcce0 ("device property: Keep secondary firmware node secondary by type") Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
There are only four valid fwnode cases which are - primary --> secondary --> -ENODEV - primary --> NULL - secondary --> -ENODEV - NULL dev->fwnode should be converted between the 4 cases above no matter how/when set_primary_fwnode() and set_secondary_fwnode() are called. Describe it in the code so people will keep it in mind. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
b6e5fa2 to
d7175bc
Compare
|
Last version looks good enough to me to be sent upstream. |
|
SOFCI TEST |
|
@lyakh Does it look good to you? |
|
SOFCI TEST |
|
Can you send these upstream, please? |
Yes, done. And I saw your |
There are only four valid fwnode cases which are
dev->fwnode should be converted between the 4 cases above no matter
how/when set_primary_fwnode() and set_secondary_fwnode() are called.
Describe it in the code so people will keep it in mind.
Fixes: #2599