Repository navigation
soundwire: slave: force fwnode as primary - #2635
Conversation
Recent changes in drivers/base/core.c modified the behavior for fwnodes. While the changes are legit and make sense, they have a ripple effect on SoundWire Slave devices. Intel validation found a corner case where in module load/unload loops, the dev->fwnode pointer is overridden with device properties, which as a result caused suspend-resume timeouts since the dev->fwnode is detected as problematic in ACPI layers. This patch forces the fwnode to be properly reinitialized as a primary node. Fixes: d5dcce0 ("device property: Keep secondary firmware node secondary by type") Tested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
|
@andy-shev @bardliao this is a tentative improvement on PR #2625, with a better commit message and removal of one change that didn't seem necessary. This works for me with 180 cycles of suspend-resume and counting. |
|
@andy-shev Sorry for the dumb question. I read the commit message of andy-shev@d5dcce0, but I still didn't get why we need it. |
Cool! From my perspective as long as it doesn't touch driver core, I'm fine with it, thanks! |
andy-shev
left a comment
There was a problem hiding this comment.
As long as it doesn't touch driver core, fine to me, thanks
|
Just to me, what kind is the check that didn't pass and why it's not critical for you? |
Hmm... I'm now puzzled what I was thinking about that time. Seems like your analysis is clear and my commit should be reverted. Seems what we need is to compile that commit message and discussion(s) here to some kind of a documentation and revert andy-shev@d5dcce0. Sorry guys for a confusion. |
|
Thanks @andy-shev much appreciated. So we don't really need this PR if andy-shev@d5dcce0 is reverted. |
Thanks for patience.
Correct. Please, prepare a revert as a new patch that brings documentation based on our discussions here somewhere in the kernel (maybe as part of |
Recent changes in drivers/base/core.c modified the behavior for
fwnodes. While the changes are legit and make sense, they have a
ripple effect on SoundWire Slave devices.
Intel validation found a corner case where in module load/unload
loops, the dev->fwnode pointer is overridden with device properties,
which as a result caused suspend-resume timeouts since the dev->fwnode
is detected as problematic in ACPI layers.
This patch forces the fwnode to be properly reinitialized as a primary
node.
Fixes: d5dcce0 ("device property: Keep secondary firmware node secondary by type")
Tested-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
Signed-off-by: Bard Liao yung-chuan.liao@linux.intel.com