Repository navigation
Conversation
We never used ACPI_SET_COMPANION which is used by others, e.g. I2C adapters. Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
requested review from
RanderWang,
jack-cy-yu,
oder-chiou,
ryans-lee and
shumingfan
as code owners
December 11, 2020 20:48
Member
Author
|
testing suggestion of @andy-shev in #2616 (comment) |
Collaborator
|
@plbossart I tested it and it worked with two changes
--- a/drivers/soundwire/slave.c
+++ b/drivers/soundwire/slave.c
@@ -61,6 +61,7 @@ int sdw_slave_add(struct sdw_bus *bus,
init_completion(&slave->probe_complete);
slave->probed = false;
slave->first_interrupt_done = false;
+ ACPI_COMPANION_SET(&slave->dev, ACPI_COMPANION(bus->dev));
for (i = 0; i < SDW_MAX_PORTS; i++)
init_completion(&slave->port_ready[i]); |
Collaborator
Sorry @plbossart I have to revise my commit. We need to set ACPI_COMPANION_SET(&slave->dev, ACPI_COMPANION(&slave->dev)); here since Slave devices are real devices. And I think we still need ACPI_COMPANION_SET() here, otherwise, set_primary_fwnode(dev, fwnode) will not be called. |
Member
Author
|
replaced by PR #2625 |
This make no sense. It's a no-op. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We never used ACPI_SET_COMPANION which is used by others, e.g. I2C
adapters.
Suggested-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com