Skip to content

ASoC: SOF: increase baytrail shim window - #1578

Merged
plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
cujomalainey:fix_byt_window
Dec 3, 2019
Merged

plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
cujomalainey:fix_byt_window

Conversation

@cujomalainey

Copy link
Copy Markdown

The window contains definitions according to the firmware headers up to
0x114 which means that it is at least 0x118. Lets share the debug
information.

Signed-off-by: Curtis Malainey cujomalainey@chromium.org

The window contains definitions according to the firmware headers up to
0x114 which means that it is at least 0x118. Lets share the debug
information.

Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>

@paulstelian97 paulstelian97 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I see no problem with that. Just correct a typo in the commit description ("Lets" -> "Let's").

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cujomalainey while we are at it, you may want to check the firmware side, the definition doesn't seem to exist:

git grep SHIM_HDMC
src/platform/baytrail/include/platform/lib/shim.h:#define SHIM_SHIM_END SHIM_HDMC

@plbossart
plbossart merged commit 2713bf3 into thesofproject:topic/sof-dev Dec 3, 2019
@cujomalainey

Copy link
Copy Markdown
Author

I noticed that as well. I will see what is going on there. Also apparently 0x118 is only for CHT. I will send a follow up PR.

@cujomalainey

Copy link
Copy Markdown
Author

Do we have any way to discern from a CHT or BYT platform at compile time? I don't think we do for the kernel, so is it ok if we let byt dump an extra 0x18 bytes?

@cujomalainey
cujomalainey deleted the fix_byt_window branch December 3, 2019 17:47
@plbossart

Copy link
Copy Markdown
Member

no, for the kernel we have to assume the build supports multiple architectures, but we have helper functions you can use e.g. soc_intel_is_cht()

I can confirm the last address for BYT is 0x0F8 (SSP2_DIV_CTRL), so the SHIM end should be 100 (excluded).

I am not sure if we want to dump undefined registers. That's asking for trouble. better to add a test and increment the size for cht to dump the additional 0x18 bytes.

@cujomalainey

Copy link
Copy Markdown
Author

turns out it was just referenced in two tables (one for byt and one for cht) so I just split the definition. #1585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants