Skip to content

ASoC: fix topology and card cleanups - #1504

Closed
plbossart wants to merge 1 commit into
thesofproject:topic/sof-devfrom
plbossart:fix/morimoto-alsa-20191113
Closed

plbossart wants to merge 1 commit into
thesofproject:topic/sof-devfrom
plbossart:fix/morimoto-alsa-20191113

Conversation

@plbossart

Copy link
Copy Markdown
Member

The initial change in #1469
does not work on Baytrail.

This fix suggested on November 13, 2019 by Morimoto-san seems to fix
the issues.

Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

The initial change in thesofproject#1469
does not work on Baytrail.

This fix suggested on November 13, 2019 by Morimoto-san seems to fix
the issues.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

@ranj063 ranj063 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@plbossart

plbossart commented Nov 16, 2019 •

Copy link
Copy Markdown
Member Author

@morimoto this works fine on Baytrail/Cherrytrail, HDAudio devices and SoundWire ones. that seems quite promising.

Edit: spoke too fast, the SoundWire test just got stuck. Gah.

Edit2: SoundWire did work, it's just that a longer delay needs to be used between cycles

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good. The CI results don't have the SDW fail @plbossart you mention your comment, so that is a potential issue, but patch itself looks good.

@plbossart

Copy link
Copy Markdown
Member Author

replaced by PR #1509

@plbossart plbossart closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants