Repository navigation
Conversation
The initial change in thesofproject#1469 does not work on Baytrail. This fix suggested on November 13, 2019 by Morimoto-san seems to fix the issues. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
This was referenced Nov 15, 2019
Member
Author
|
@morimoto this works fine on Baytrail/Cherrytrail, HDAudio devices and SoundWire ones. that seems quite promising. Edit: spoke too fast, the SoundWire test just got stuck. Gah. Edit2: SoundWire did work, it's just that a longer delay needs to be used between cycles |
kv2019i
approved these changes
Nov 18, 2019
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
The patch looks good. The CI results don't have the SDW fail @plbossart you mention your comment, so that is a potential issue, but patch itself looks good.
Member
Author
|
replaced by PR #1509 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial change in #1469
does not work on Baytrail.
This fix suggested on November 13, 2019 by Morimoto-san seems to fix
the issues.
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com