Skip to content

CI: add support for Coccinelle #454

Closed

Description

@plbossart

Coccinelle is an extremely useful tool to detect conceptual errors or bad programming.
In 30mn it found one memory leak issue and one useless function, see #453

let's add it to the CI (both Travis and Intel). Coccinelle version 1.0.7 is needed and may need to be build from code. It's easy to create a new Debian package

apt-get build-dep coccinelle
git clone https://github.com/coccinelle/coccinelle.git
cd coccinelle
git checkout 1.0.7
./autogen.sh
./configure
make -j4
make install (or create .deb)

https://bottest.wiki.kernel.org/coccicheck

for CI, let's use this command line
make coccicheck MODE=report M=sound/soc/sof

Same as for Sparse, we only need to check SOF, not solve world hunger.

Activity

  1. xiulipan commented on Dec 17, 2018

    @xiulipan

    @plbossart
    Noted. Will enable it after local test success.

  2. xiulipan commented on Dec 17, 2018

    @xiulipan

    @plbossart
    apt-get have a released binary of 1.0.4
    For travis-ci. I would like to use some pre-build one. Since I found a lot of dependency (about 400mb) is needed to build from binary. It will make travis-ci even slower.

  3. plbossart commented on Dec 17, 2018

    @plbossart
    MemberAuthor
  4. xiulipan commented on Dec 18, 2018

    @xiulipan

    @plbossart
    I will update that once we get a server that can be access from Internet.
    Let use 1.0.4 for travis CI for now. #462

  5. plbossart commented on Dec 18, 2018

    @plbossart
    MemberAuthor
  6. plbossart commented on Jun 10, 2019

    @plbossart
    MemberAuthor

    @xiulipan this is still outstanding, it's a really good check to add.

  7. xiulipan commented on Jun 11, 2019

    @xiulipan

    @plbossart
    I will try to prebuild the coccinelle and upload it to 01.org to reduce the time cost for travis ci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions