You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Coccinelle is an extremely useful tool to detect conceptual errors or bad programming.
In 30mn it found one memory leak issue and one useless function, see #453
let's add it to the CI (both Travis and Intel). Coccinelle version 1.0.7 is needed and may need to be build from code. It's easy to create a new Debian package
apt-get build-dep coccinelle
git clone https://github.com/coccinelle/coccinelle.git
cd coccinelle
git checkout 1.0.7
./autogen.sh
./configure
make -j4
make install (or create .deb)
@plbossart
apt-get have a released binary of 1.0.4
For travis-ci. I would like to use some pre-build one. Since I found a lot of dependency (about 400mb) is needed to build from binary. It will make travis-ci even slower.
On 12/17/18 1:29 AM, xiulipan wrote:
@plbossart <https://github.com/plbossart>
apt-get have a released binary of 1.0.4
For travis-ci. I would like to use some pre-build one. Since I found a
lot of dependency (about 400mb) is needed to build from binary. It
will make travis-ci even slower.
You can provide a debian package based on 1.0.7, it's no big deal.
On 12/17/18 11:14 PM, xiulipan wrote:
@plbossart <https://github.com/plbossart>
I will update that once we get a server that can be access from Internet.
Let use 1.0.4 for travis CI for now. #462
<#462>
It's not going to work. I tried on my local machine and had a couple of
errors due to the version mismatch. If we don't have a means to update
to 1,.0.7 we need to wait or we'll have errors all the time.
Activity
xiulipan commentedon Dec 17, 2018
@plbossart
Noted. Will enable it after local test success.
xiulipan commentedon Dec 17, 2018
@plbossart
apt-get have a released binary of 1.0.4
For travis-ci. I would like to use some pre-build one. Since I found a lot of dependency (about 400mb) is needed to build from binary. It will make travis-ci even slower.
plbossart commentedon Dec 17, 2018
xiulipan commentedon Dec 18, 2018
@plbossart
I will update that once we get a server that can be access from Internet.
Let use 1.0.4 for travis CI for now. #462
plbossart commentedon Dec 18, 2018
plbossart commentedon Jun 10, 2019
@xiulipan this is still outstanding, it's a really good check to add.
xiulipan commentedon Jun 11, 2019
@plbossart
I will try to prebuild the coccinelle and upload it to 01.org to reduce the time cost for travis ci.
bpf, sockmap: Remove bucket->lock from sock_{hash|map}_free
Merge branch 'selftests-bpf-convert-test_tc_tunnel-sh-to-test_progs'