Skip to content

Declutter - #1

Open
ale-rt wants to merge 1 commit into
mainfrom
ale/declutter
Open

ale-rt wants to merge 1 commit into
mainfrom
ale/declutter

Conversation

@ale-rt

@ale-rt ale-rt commented Nov 4, 2026

Copy link
Copy Markdown
Member

Why you ask?
It proved to be not useful and everytime I have to waste time removing stuff.

Motivation

Refs #

Change

Verified by

  • [ ]

Status

Open for review

Why you ask?
It proved to be not useful and everytime I have to waste time removing
stuff.
@ale-rt
ale-rt requested a review from pilz November 4, 2026 07:15

@thet thet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but I'd keep Refs #.

Comment thread pull_request_template.md
never by person ("f6339e1 introduced…", not "you/X introduced…").
Answer the obvious "why is this needed?" here, upfront. -->

Refs #

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Refs # is good - I add it always to my PRs unless I forget it. And for that, this Refs # is a good reminder.

It should link to a scrum ticket, or whetever other reference is applicable.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refs. should be in your commit message

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO also in the ticket to have a reference where to book the task on, e.g. when doing a PR review.
But we're doing that anyways, it would just be a convenient reminder.
I don't care removing it though.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, check https://handbook.syslab.com/developers-guide/chapters/02_development_standards.html

But ideally you have 1 commit per PR and that's automatically fulfilled.
We do not need any of this.

@thet
thet self-requested a review November 11, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants