Skip to content

Replace 1/x with inv(x) - Corrected - #631

Merged
mitzimorris merged 2 commits into
stan-dev:developfrom
andrjohns:feature/issue-595-replace-1/x-inv(x)
Oct 1, 2017
Merged

mitzimorris merged 2 commits into
stan-dev:developfrom
andrjohns:feature/issue-595-replace-1/x-inv(x)

Conversation

@andrjohns

Copy link
Copy Markdown
Collaborator

Submission Checklist

  • Run unit tests: ./runTests.py test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary:

Corrected files causing develop to fail after merging original pull request #626. Verified locally with make -j4 test-headers

Intended Effect:

Make code more efficient/consistent

How to Verify:

Side Effects:

Documentation:

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@stan-buildbot

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@mitzimorris mitzimorris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - many thanks for the extensive code cleanup!

@mitzimorris
mitzimorris merged commit a45125f into stan-dev:develop Oct 1, 2017
@seantalts

Copy link
Copy Markdown
Member

@mitzimorris this didn't get tested on Jenkins and broke develop - when you see the comment from stan-buildbot above asking if one of the admins can verify this patch, one of us has to write "Jenkins, ok to test" to it so it will run tests on Jenkins. I'm going to revert this merge - @andrjohns if you wouldn't mind opening a new PR with this and tagging me - I think I'm going to have Jenkins run on anyone's PRs for now.

seantalts added a commit that referenced this pull request Oct 2, 2017
…ace-1/x-inv(x)"

This reverts commit a45125f, reversing
changes made to bd4d8c3.
@mitzimorris

Copy link
Copy Markdown
Member

extremely sorry - I thought that it had passed all tests.

@bob-carpenter

bob-carpenter commented Oct 2, 2017 via email

Copy link
Copy Markdown
Member

@andrjohns
andrjohns deleted the feature/issue-595-replace-1/x-inv(x) branch March 14, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants