Repository navigation
Replace 1/x with inv(x) - Corrected - #631
Merged
mitzimorris merged 2 commits intoOct 1, 2017
Merged
mitzimorris merged 2 commits into
mitzimorris merged 2 commits into
Conversation
Contributor
|
Can one of the admins verify this patch? |
mitzimorris
approved these changes
Oct 1, 2017
mitzimorris
left a comment
Member
There was a problem hiding this comment.
looks good - many thanks for the extensive code cleanup!
Member
|
@mitzimorris this didn't get tested on Jenkins and broke develop - when you see the comment from stan-buildbot above asking if one of the admins can verify this patch, one of us has to write "Jenkins, ok to test" to it so it will run tests on Jenkins. I'm going to revert this merge - @andrjohns if you wouldn't mind opening a new PR with this and tagging me - I think I'm going to have Jenkins run on anyone's PRs for now. |
Member
|
extremely sorry - I thought that it had passed all tests. |
Member
|
I did the same thing with the same pull request. These remote pull requests are still confusing me.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
./runTests.py test/unitmake cpplintSummary:
Corrected files causing develop to fail after merging original pull request #626. Verified locally with
make -j4 test-headersIntended Effect:
Make code more efficient/consistent
How to Verify:
Side Effects:
Documentation:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: