Repository navigation
Revert reverted matrix cl refactor - #1451
Conversation
|
@serban-nicusor-toptal is Jenkins acting up? I might just have a Jenkinsfile issue here, though I think something weird is going on. If you are already aware then sorry for the spam. |
|
@rok-cesnovar Jenkins has some issues, I'm working on fixing it up and bringing it online. |
|
Thank you for the extremely quick reply! Good luck making Jenkins to obey :) |
|
@rok-cesnovar Jenkins looks sane now. I've restarted your job but it failed w/o any error ... If this is an issue from Jenkins please let me know so we can sort it out. |
|
Probably a goof on my part. Thanks! |
|
I think the gelman-group-linux is down, judging from the errors: |
|
Hey Rok, I've noticed that while running it looses connection. This is possibly an issue because of an upgrade of some plugins, yay Jenkins. This should be solved shortly. |
|
I feel your pain @serban-nicusor-toptal :/ Thanks for your quick responses, as always. |
|
@rok-cesnovar I've figured it out but now it fails because of a test, can you please check it out and let me know if it's an issue from Jenkins ? Thanks! |
|
Its correct that it fails on this test. Its the reason for this PR because this is the exact machine it was failing on. |
|
!! Excellent Rok thank you for the diligence here! |
|
(stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan, 1.0) |
t4c1
left a comment
There was a problem hiding this comment.
Thanks for finding out exact line of code with a bug. That makes it easy to see what is wrong - perfect forwarding is missing here. I think the following changes should fix it.
Also there is no major difference between the overloads. Others are probably missing some tests.
Co-Authored-By: Tadej Ciglarič <tadej.c@gmail.com>
Co-Authored-By: Tadej Ciglarič <tadej.c@gmail.com>
Co-Authored-By: Tadej Ciglarič <tadej.c@gmail.com>
|
Thanks! Added the fixes, lets see. |
|
(stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan, 0.99) |
|
Ok, this one seems to be squashed. Ready for review. |
t4c1
left a comment
There was a problem hiding this comment.
One question and a problem with a merge.
| * @param A the vector of Eigen matrices | ||
| * | ||
| * @throw <code>std::invalid_argument</code> if the | ||
| * matrices do not have matching dimensions | ||
| * @throw <code>std::system_error</code> if the memory on the device could not | ||
| * be allocated |
There was a problem hiding this comment.
I think you lost part of this comment in a merge. Same with the changes in lines 377 and 391 of the original refactor, but I can't comment there since there are no changes there in your PR.
|
(stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan, 0.99) |
|
(stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan, 0.99) |
|
(stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan, 1.0) |
|
(stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan, 1.0) |
Summary
This PR will attempt to revert back the revert in #1428
For now, this modifies the Jenkinsfile severely in order to only run the tests on the machine they failed on, have a faster turnaround and not clog the Jenkins workers. The first goal is to consistently repeat the failing tests on Jenkins and then find a fix.
Tests
Side Effects
Are there any side effects that we should be aware of?
Checklist
Math issue #
Copyright holder: Rok Češnovar
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested