Repository navigation
deduplicate matrix_cl code - #1407
Conversation
# Conflicts: # stan/math/opencl/matrix_cl.hpp
…xp1~20180509124008.99 (branches/release_50)
rok-cesnovar
left a comment
There was a problem hiding this comment.
Looks good! Thanks for cleaning this up. Just needs to pass on Jenkins.
The last error was:
ar: creating lib/sundials_4.1.0/lib/libsundials_idas.a
ar: unable to rename 'lib/sundials_4.1.0/lib/libsundials_idas.a'; reason: Permission denied
ar: creating lib/sundials_4.1.0/lib/libsundials_cvodes.a
make/libraries:64: recipe for target 'lib/sundials_4.1.0/lib/libsundials_idas.a' failed
mingw32-make: *** [lib/sundials_4.1.0/lib/libsundials_idas.a] Error 1
I restared the part 2 tests. These are the relevant tests running now: https://jenkins.mc-stan.org/blue/organizations/jenkins/Math%20Pipeline/detail/PR-1407/8/pipeline
|
(stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan, 1.0) |
Revert "pull request #1407 from bstatcomp/matrix_cl_refactor"
Summary
This refactors
matrix_cl.hppandcopy.hppto remove lots of code duplication. Some errors in documentation formatrix_clare also fixed.Tests
None, just a refactor.
Side Effects
None
Checklist
Math issue matrix_cl.hpp contains lots of duplicated code #1406
Copyright holder: Tadej Ciglarič
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested