Skip to content

deduplicate matrix_cl code - #1407

Merged
rok-cesnovar merged 5 commits into
stan-dev:developfrom
bstatcomp:matrix_cl_refactor
Oct 25, 2019
Merged

rok-cesnovar merged 5 commits into
stan-dev:developfrom
bstatcomp:matrix_cl_refactor

Conversation

@t4c1

@t4c1 t4c1 commented Oct 17, 2019 •

Copy link
Copy Markdown
Contributor

Summary

This refactors matrix_cl.hpp and copy.hpp to remove lots of code duplication. Some errors in documentation for matrix_cl are also fixed.

Tests

None, just a refactor.

Side Effects

None

Checklist

  • Math issue matrix_cl.hpp contains lots of duplicated code #1406

  • Copyright holder: Tadej Ciglarič

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@serban-nicusor-toptal serban-nicusor-toptal added this to the 3.0.0++ milestone Oct 18, 2019
t4c1 and others added 3 commits October 24, 2019 09:16

@rok-cesnovar rok-cesnovar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for cleaning this up. Just needs to pass on Jenkins.

The last error was:

ar: creating lib/sundials_4.1.0/lib/libsundials_idas.a
ar: unable to rename 'lib/sundials_4.1.0/lib/libsundials_idas.a'; reason: Permission denied
ar: creating lib/sundials_4.1.0/lib/libsundials_cvodes.a
make/libraries:64: recipe for target 'lib/sundials_4.1.0/lib/libsundials_idas.a' failed
mingw32-make: *** [lib/sundials_4.1.0/lib/libsundials_idas.a] Error 1

I restared the part 2 tests. These are the relevant tests running now: https://jenkins.mc-stan.org/blue/organizations/jenkins/Math%20Pipeline/detail/PR-1407/8/pipeline

@stan-buildbot

Copy link
Copy Markdown
Contributor

(stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan, 1.0)
(stat_comp_benchmarks/benchmarks/low_dim_corr_gauss/low_dim_corr_gauss.stan, 0.99)
(stat_comp_benchmarks/benchmarks/irt_2pl/irt_2pl.stan, 1.0)
(stat_comp_benchmarks/benchmarks/pkpd/one_comp_mm_elim_abs.stan, 0.97)
(stat_comp_benchmarks/benchmarks/eight_schools/eight_schools.stan, 1.01)
(stat_comp_benchmarks/benchmarks/gp_regr/gp_regr.stan, 1.02)
(stat_comp_benchmarks/benchmarks/arK/arK.stan, 1.0)
(performance.compilation, 1.02)
(stat_comp_benchmarks/benchmarks/low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan, 1.0)
(stat_comp_benchmarks/benchmarks/low_dim_gauss_mix/low_dim_gauss_mix.stan, 1.0)
(stat_comp_benchmarks/benchmarks/sir/sir.stan, 0.98)
(stat_comp_benchmarks/benchmarks/pkpd/sim_one_comp_mm_elim_abs.stan, 0.94)
(stat_comp_benchmarks/benchmarks/garch/garch.stan, 1.01)
(stat_comp_benchmarks/benchmarks/gp_regr/gen_gp_data.stan, 0.99)
(stat_comp_benchmarks/benchmarks/arma/arma.stan, 0.99)
Result: 0.99430423984
Commit hash: d04dcfe

@rok-cesnovar
rok-cesnovar merged commit 6723f81 into stan-dev:develop Oct 25, 2019
@rok-cesnovar
rok-cesnovar deleted the matrix_cl_refactor branch October 25, 2019 09:58
SteveBronder added a commit that referenced this pull request Nov 3, 2019
…_refactor"

This reverts commit 6723f81, reversing
changes made to 6455b69.
SteveBronder added a commit that referenced this pull request Nov 4, 2019
Revert "pull request #1407 from bstatcomp/matrix_cl_refactor"
@t4c1 t4c1 mentioned this pull request Nov 6, 2019
5 tasks done
@serban-nicusor-toptal serban-nicusor-toptal modified the milestones: 3.0.0++, 3.1.0 Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants