Skip to content

rename probability functions #320

Closed
Closed

Description

@bob-carpenter

Summary:

Rename probability functions to match the language definitions.

Description:

  • _log to _lpdf or _lpmf
  • _log_cdf to _lcdf
  • _log_ccdf to _lccdf

This will hugely simplify the code generation component of Stan.

To Do

  • Rename functions
    • Update function name
    • Update documentation
    • Update file name
    • Update tests
  • Figure out how to test distributions (might not need to change the generated code)
  • Update makefile appropriately

Current Version:

v2.10.0

Activity

  1. added this to the milestone on Jul 25, 2016
  2. syclik commented on Oct 14, 2016

    @syclik
    Member

    Do we need to worry about backwards compatibility here?

    • normal_log() should be renamed to normal_lpdf()
    • Do we need to keep a normal_log() function that's deprecated that calls normal_lpdf(); if so, how do we deal with deprecation?
  3. bob-carpenter commented on Oct 14, 2016

    @bob-carpenter
    MemberAuthor
  4. syclik commented on Oct 14, 2016

    @syclik
    Member

    Thanks. That makes sense.

    On Fri, Oct 14, 2016 at 11:25 AM, Bob Carpenter notifications@github.com
    wrote:

    We need to maintain backward compatibility until Stan 3.0.
    At that point, I can do the do-si-do in stan-dev/stan to get
    rid of the _log suffixes in the math lib and the language.

    For now, we should add a doxygen command for each of the _log
    forms:

    @deprecated ---how to replace it---

    along with the @PARAM etc. See:

    https://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmddeprecated

    —
    You are receiving this because you were assigned.
    Reply to this email directly, view it on GitHub
    #320 (comment), or mute
    the thread
    https://github.com/notifications/unsubscribe-auth/AAZ_FyrPinL2zcxv5eAFTCfSbrSugIudks5qz58HgaJpZM4JTuYn
    .

  5. added 2 commits that reference this issue on Nov 22, 2016
    20a31bc
    d3186d9
  6. added a commit that references this issue on Feb 13, 2017
    67c02e9
  7. modified the milestones: , 2.18.0 on Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions