Repository navigation
refactor(emcn): split the Platform design system into packages - #9764
emir-karabeg wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[High impact] The package split reaches UI across the main app, Platform, Auth, Docs, and embedded views. The PR appears safe to merge with two non-blocking UI regressions to fix. Findings
SummarySplits the design system into shared EMCN and Auth, Docs and Platform packages, while moving existing controls to
|
Comments Outside DiffThese findings could not be posted inline.
|
There was a problem hiding this comment.
1 issue found across 2709 files
Confidence score: 4/5
- In
api-reference.tsx, theNeutralBadgestretches across the column, so the “Deprecated operation” pill no longer fits its content. Keep the badge aligned to its content width.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/docs/components/docs/api-reference/api-reference.tsx">
<violation number="1" location="apps/docs/components/docs/api-reference/api-reference.tsx:102">
P3: Switching this container to `flex flex-col` makes the direct child `NeutralBadge` (an `inline-flex` span) stretch to full width, so the "Deprecated operation" pill now spans the whole column. The previous `space-y-8` block layout kept it shrink-wrapped; either revert this className or add `self-start` to the badge.</violation>
</file>
Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
Turn on auto-fix | Re-trigger cubic
This comment has been minimized.
This comment has been minimized.
- Credential rows on an app's page wear that app's mark, so a shared Google credential no longer shows Gmail under Google BigQuery. - The MCP glyph is an interface icon and takes the shared icon ink, like the skill and key glyphs. Integration marks keep their own paint. - The integration center renders its heading, and app details their Back link, from the same nuqs state that picks the view. Going back no longer flashes the previous view's chrome for a few frames. - Sidebar, Home and Integrations paint nothing while loading: no route loading.tsx, no widget skeletons, no loading copy. The shell's unkeyed Suspense keeps the current page through a navigation, and a page load paints the sidebar first. The calendar keeps its hour grid while a day loads. The rule is recorded in apps/sim/platform/AGENTS.md.
Summary
Moves the Platform design system out of
apps/sim/platform/design-systeminto workspace packages, on top of the integration center (#9725) and the latestplatform-core-chat:packages/emcnholds shared controls, tokens, fonts and recipes;packages/emcn-platformholds Platform compositions;packages/emcn-authandpackages/emcn-docshold the Auth and Docs surfaces. The old package is now@sim/emcn-legacy, so@sim/emcnmeans the modern package everywhere.embedded/,shared/andapp/oimport public family subpaths (@sim/emcn/<family>,@sim/emcn-platform/<family>). Package code uses its private#emcn/#platformaliases.check:platform-design,check:platform-cssandcheck:boundariescombine package ownership with the embedded/shared/convergence rules. Their tests and the CI change fixture model the packages.For the
embedded/ownerThese change what the organization views render or import, following the zone:
Selects becameChoiceMenu. QuietMultiSelect/SearchableSelectusevariant='text'. Pickers have noquietvariant, andSelecthas noblock.ActivityRowusestextMetadata(paired withpeople).DataTablecolumns takesharefor a percentage share;widthkeepscompact/regular.Hydratedmoved toapp/o/[organizationId]/components/hydrated.tsx: hydration belongs to the host, not a UI package.canvas, and the host bridge names theEMCN Geistfamily.Verification
Run locally on the merge commit
5f2fc54e6b, before the docs-only commit on top:origin/staging.gateway.server,egress-end-to-end.server,processing-recovery-queue-transport) fail under the local Node 23.10, as they do before this change, and pass under Node 24.19.checks/live), which needs a running app and database.Details and the decisions above are in
apps/sim/platform/docs/consolidation-checkpoint.md.🤖 Generated with Claude Code