Skip to content

fix(search): preserve provider guidance for personal connections - #9752

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/search-credential-error-feedback
Nov 6, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/search-credential-error-feedback

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve provider-specific credential guidance when connecting personal Search accounts through the shared connection modals.
  • Reuse the existing error mappers for Jama and Flow while retaining Search-specific messages for identity and approval failures and the existing fallback for ordinary credentials.

Type of Change

  • Bug fix

Testing

  • Compared the original and updated modals against the same local HTTP error fixtures. Verified credential, host, availability, identity, approval, and fallback messages.
  • Passed the focused credential and API-client suites, lint, all workspace type checks, all 62 audits, test-type checks, generated-artifact checks, and the block-registry check. Full suites run in CI.
  • No live provider authentication behavior changes.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (verified with existing tests and local UI fixtures)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 6, 2026 8:00pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Personal Search connections now use the shared provider error messages for Jama and Flow.

  • Personal Search saves keep provider guidance and Search-specific error messages.

Reviews (1) · Last reviewed commit: "fix(search): preserve provider guidance ..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 4505fb9 into staging Nov 6, 2026
79 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-credential-error-feedback branch November 6, 2026 20:07

This branch was previously deployed

1 inactive deployment
Preview — a16cef3d Deployed Nov 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant