improvement(org): move the People page onto the new design system by waleedlatif1 · Pull Request #9720 · simstudioai/sim

waleedlatif1 · 2026-11-05T22:12:01Z

Summary

Rebuild People on the embedded design system (same mount as Home, Links, Integrations): org chart, directory, profile, directory sync, connect, import
Org chart matches the Paper prototype: person cards, focused state, reporting bus, breadcrumb, zoom and fit controls, four reports per page on desktop, one branch with a compact manager on mobile
Find a person is a real search field with two-line results (title and department) and keyboard hints
Directory sync is now a page at the existing ?panel=sync URL, with a summary for each state: connected, first sync, syncing, publishing, waiting to retry, failed, paused
First use for an admin offers Okta, Entra and SCIM plus Import profiles; a member gets a neutral state pointing at the directory
Profile is two columns with Copy profile link; invalid or inaccessible links get a neutral recovery state
Page gate moves to canBrowsePeople, so a member withheld the directory gets a 404 from a saved link, matching the sidebar
Sync actions share one org-wide in-flight guard, since the page and the connect dialog each hold actions now
Initial sync status reads no longer invalidate every People query
Move the parsers and sheet reader to lib/people, matching Build the Platform Core, Chat, and member integrations UI #9687
Delete the legacy People views and the ResourceLoadError they orphaned; LinksSurface becomes a shared RedesignPageSurface

Design-system additions, each with a People consumer: SearchCombobox, Avatar row/card/hero, DataTable primary and rowChevron, SearchableSelect variant='text', users and minus glyphs. EmptyState now lays out its own action row instead of restyling any div it is given.

Where the prototype and the #9687 contract disagree, this follows the contract:

No row dividers in the directory or profile lists (lines are reserved for surface boundaries)
Single-initial avatars
Dialogs use the shared Modal chrome
Disconnect is the solid destructive button
Directory load-more is automatic through the table owner, not a button

Deliberate departures from the prototype:

Header keeps Import beside Directory sync once a chart exists, so admins don't lose it
Mobile keeps the breadcrumb, so top-level teams stay reachable
Profile rows center the avatar as Paper draws them instead of using ActivityRow, whose leading slot can't hold it (the contract asks for first-line alignment)
Underline tabs are local to People, as Paper draws them (the contract points horizontal destinations at ControlRow)

Heads up for #9687: its branch has its own people/ tree at many of the same paths, so that rebase needs to pick this implementation.

Type of Change

Improvement

Testing

test-people-e2e.ts against a running app and real Postgres in hosted mode: 20/20, browser journey updated for the new UI and extended to the header entry points
test-org-redesign-e2e.ts People phase updated; runs in CI, not run locally
bun run --cwd apps/sim test lib/people and the organization layout test: 56 passed
type-check, lint, check:platform-css, check:source-conventions, check:comment-hygiene, check:file-names, check:utils, check:client-boundary, check:explicit-any, check:boundaries, check:test-patterns, block registry
Full check:audits and root bun run test left to CI
Rendered every state against the Paper artboards: light and dark on the chart, 1440, 1024 and 390 wide. Sync states used a mocked status response
Not exercised against a real Okta or Entra tenant

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-11-05T22:12:04Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Nov 5, 2026 10:59pm UTC

greptile-apps · 2026-11-05T22:15:33Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues remain from this review.

Summary

Moves People onto the shared design system, including the org chart, directory, profiles, imports, and directory sync.

The org chart centers on a person and lets people explore reporting lines.
The directory leads to searchable people profiles with manager and report details.
Directory sync has its own page for connection status and actions.
Administrators can import profiles from a shared People import flow.
People routes share a page frame and gate access to the directory.

_{Reviews (3) · Last reviewed commit: "fix(people): keep the publish refresh on..." · Reviewed by Greptile}

cubic-dev-ai

All reported issues were addressed across 69 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

…n disconnect

waleedlatif1 · 2026-11-05T22:45:21Z

@greptile

waleedlatif1 · 2026-11-05T22:45:22Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-05T22:45:28Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 70 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

…he SCIM status read from load

waleedlatif1 · 2026-11-05T22:59:08Z

@greptile

waleedlatif1 · 2026-11-05T22:59:09Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-05T22:59:16Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 70 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

* Revert "improvement(org): move the People page onto the new design system (#9720)" This reverts commit 7625929. * Revert "fix(org): drop the removed shortcuts slot from the landing test (#9715)" This reverts commit f17f1b6. * Revert "improvement(org): move the organization view onto the new design system (#9708)" The redesigned org view ships all at once with #9687. The shared modules later staging work builds on stay: member-integrations and the accounts key factory. The legacy integration detail opens the saved-credential modal for Jama and Flow, which #9723 added only to the new view. * fix(org): keep staging's shared modules and revert only the redesigned views Hooks, contracts, key factories and lib helpers stay at staging, and the legacy view adapts to them. Jama and Flow reconnect through the saved-credential modal and disconnect through Search. Exports only the new views used are unexported or deleted, and the e2e script returns to the legacy view's selectors.

improvement(org): move the People page onto the new design system

d2ff3b7

vercel Bot temporarily deployed to Preview November 5, 2026 22:12 Inactive

greptile-apps Bot reviewed Nov 5, 2026

View reviewed changes

Comment thread apps/sim/platform/app/(shell)/people/_components/person/person-modal.tsx Resolved

cubic-dev-ai Bot reviewed Nov 5, 2026

View reviewed changes

Comment thread apps/sim/platform/lib/data/people.ts Resolved

Comment thread apps/sim/platform/app/(shell)/people/_components/directory-sync/directory-sync-page.tsx Resolved

Comment thread apps/sim/platform/app/(shell)/people/_components/person/person-modal.tsx Resolved

fix(people): settle header actions, narrow refusals, refresh people o…

fd71904

…n disconnect

vercel Bot temporarily deployed to Preview November 5, 2026 22:45 Inactive

cubic-dev-ai Bot reviewed Nov 5, 2026

View reviewed changes

Comment thread apps/sim/hooks/queries/people-sync.ts Resolved

fix(people): keep the publish refresh on cold status reads and fail t…

4f370ef

…he SCIM status read from load

vercel Bot temporarily deployed to Preview November 5, 2026 22:59 Inactive

cubic-dev-ai Bot reviewed Nov 5, 2026

View reviewed changes

waleedlatif1 merged commit 7625929 into staging Nov 5, 2026
79 of 80 checks passed

waleedlatif1 deleted the improvement/org-people-redesign branch November 5, 2026 23:16

waleedlatif1 mentioned this pull request Nov 6, 2026

revert(org): hold the org view and People redesigns for #9687 #9740

Merged

1 task done

waleedlatif1 mentioned this pull request Nov 6, 2026

v0.9.45: AWS Marketplace contracts, multiple accounts per integration, Thinking Machines provider, Gauge Chat, Jama and Flow search, request ids in log metadata #9744

Merged

Conversation

waleedlatif1 commented Nov 5, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 5, 2026

Uh oh!

waleedlatif1 commented Nov 5, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 5, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Nov 5, 2026

Uh oh!

waleedlatif1 commented Nov 5, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 5, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Nov 5, 2026 •

edited

Loading

greptile-apps Bot commented Nov 5, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading