Skip to content

improvement(enrichments): consolidate lookups through Firecrawl - #9707

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/firecrawl-enrichments
Nov 5, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/firecrawl-enrichments

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Route work email, phone, LinkedIn, company domain, and company information enrichments through Firecrawl Alexandria. Keep ZeroBounce as the single email verifier.
  • Preserve existing enrichment inputs and output columns, meter reported Firecrawl credits, and surface provider failures without treating them as matches.
  • Remove obsolete provider cascades, failure adapters, helpers, and provider-specific tests. Expose the new lookup operation in the Firecrawl block.

Type of Change

  • Improvement

Testing

Eight live provider checks cover all five enrichment types, both LinkedIn lookup paths, and single-part-name no-match handling, with repeatable JSON reports. The name regression fails on the previous code and passes with the fix. Focused tests cover provider error envelopes, no-match handling, PDL contact mapping, verification status, and billing. Cleanup and test-audit passes are complete. Full workspace tests, lint, type-check, repository audits, and the block registry audit pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 5, 2026 10:28am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Routes five enrichment types through Firecrawl Alexandria and keeps ZeroBounce for email verification.

  • Five enrichment lookups now run through Firecrawl Alexandria.
  • Firecrawl workflows can look up a person or company.
  • Email verification now uses ZeroBounce alone.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Table enrichment or Firecrawl block] --> B[Firecrawl Alexandria]
  B --> C{Lookup inputs}
  C -->|Contact with LinkedIn URL or first and last name| D[FullEnrich]
  C -->|Single-part contact name| E[People Data Labs]
  C -->|Name-based LinkedIn or company lookup| E
  D --> F[Map results and reported credits]
  E --> F
  F --> G[Return match, clean miss, or provider error]
Loading

Reviews (2) · Last reviewed commit: "fix(enrichments): preserve single-part n..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 25 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/firecrawl.ts Resolved
Comment thread apps/sim/blocks/blocks/firecrawl.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 26 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was successfully deployed

1 active deployment
Preview — 130914a4 Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant