Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/casclient/responses.rb
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,15 @@ def parse_http_response(http_response)
if location =~ /ticket=([^&]+)/
@ticket = $~[1]
end

if not ((http_response.kind_of?(Net::HTTPSuccess) || http_response.kind_of?(Net::HTTPFound)) && @ticket.present?)

# Legacy check. CAS Server used to return a 200 (Success) or a 302 (Found) on successful authentication.
# This behavior should be deprecated at some point in the future.
legacy_valid_ticket = (http_response.kind_of?(Net::HTTPSuccess) || http_response.kind_of?(Net::HTTPFound)) && @ticket.present?

# If using rubycas-server 1.1.0+
valid_ticket = http_response.kind_of?(Net::HTTPSeeOther) && @ticket.present?

if !legacy_valid_ticket && !valid_ticket
@failure = true
# Try to extract the error message -- this only works with RubyCAS-Server.
# For other servers we just return the entire response body (i.e. the whole error page).
Expand Down