Repository navigation
Remove "." segments from the base path in URI#merge #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0z5a
wants to merge
1
commit into
ruby:master
Choose a base branch
from
0z5a:fix/merge-base-dot-segments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can now drop the root
/. Before, a.right after the root took the hit from the next... Now the.is skipped, so that..pops the root''segment instead, and the merged path comes out empty or relative:I ran 20k random bases built from
.,..,b,c,dand empty segments, joined withg,g/,./g,../g,?q,#f,.,..,g/../h. Results with an empty path: master 504, this PR 648. 93 of them are new (fine on master), all from a.that is now skipped next to a..that removes the root (/./.., or/../.where the.used to stay as a segment).One fix that removes all of them (0 in the same run) is to never pop the root:
The suite then has one failure, the pinned
http://h/a/../..//y+zcase intest_merge_path_dot_dot_removal. It becomeshttp://h//z, which is what RFC 3986 5.2.4 gives, but that test pins the old output on purpose. So you may want a narrower fix there.