Repository navigation
Closed
Description
Thanks in advance for your work on this library.
URI::PATTERN constant has existed for a long time, since at least ruby 2.1/ URI 0.9.11. It looks like URI 1.0.0 dropped it without deprecating it. Was this intentional?
% ruby -e "puts RUBY_VERSION; require 'uri'; puts URI::VERSION; puts URI::PATTERN"
3.3.5
0.13.1
URI::RFC2396_REGEXP::PATTERN
% ruby -e "puts RUBY_VERSION; require 'uri'; puts URI::VERSION; puts URI::PATTERN"
3.3.5
1.0.0
/Users/joerafaniello/.gem/ruby/3.3.5/gems/uri-1.0.0/lib/uri/common.rb:53:in `const_missing': uninitialized constant URI::PATTERN (NameError)
from -e:1:in `<main>'
Running all-ruby, we can see it's been there a long time. If we can't use it, please deprecate it and suggest a replacement. Thanks!
% podman run --rm -e "ALL_RUBY_SHOW_DUP=yes" -e "ALL_RUBY_SINCE=ruby-2.1" -e "ALL_RUBY_ADDBINS=/usr/bin/ruby" rubylang/all-ruby ./all-ruby -e 'require "uri"; puts "version: #{URI::VERSION} pattern: #{URI::PATTERN}"'
WARNING: image platform (linux/amd64) does not match the expected platform (linux/arm64)
ruby-2.1.0 version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.1 version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.2 version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.3 version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.4 version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.5 version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.6 version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.7 version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.8 version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.9 version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.10 version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.2.0-preview1 version: 0.9.11 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.0-preview2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.0-rc1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.0 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.3 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.4 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.5 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.6 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.7 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.8 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.9 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.10 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.0-preview1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.0-preview2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.0 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.3 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.4 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.5 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.6 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.7 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.8 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.0-preview1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.0-preview2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.0-preview3 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.0-rc1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.0 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.3 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.4 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.5 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.6 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.7 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.9 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.10 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.0-preview1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.0-rc1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.0 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.3 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.4 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.5 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.6 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.7 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.8 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.9 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.0-preview1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.0-preview2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.0-preview3 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.0-rc1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.0-rc2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.0 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.3 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.4 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.5 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.6 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.7 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.8 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.9 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.10 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.0-preview1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.0-preview2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.0-preview3 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.0-rc1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.0-rc2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.0 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.3 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.4 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.5 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.6 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.7 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.8 version: 0.10.0.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.0-preview1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.0-preview2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.0-rc1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.0 version: 0.10.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.1 version: 0.10.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.2 version: 0.10.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.3 version: 0.10.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.4 version: 0.10.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.5 version: 0.10.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.6 version: 0.10.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.7 version: 0.10.3 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.0-preview1 version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.0 version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.1 version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.2 version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.3 version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.4 version: 0.12.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.5 version: 0.12.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.6 version: 0.12.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.0-preview1 version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.0-preview2 version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.0-preview3 version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.0-rc1 version: 0.12.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.0 version: 0.12.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.1 version: 0.12.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.2 version: 0.12.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.3 version: 0.12.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.4 version: 0.12.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.5 version: 0.12.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.6 version: 0.12.3 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.0-preview1 version: 0.12.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.0-preview2 version: 0.12.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.0-preview3 version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.0-rc1 version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.0 version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.1 version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.2 version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.3 version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.4 version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.5 version: 0.13.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.6 version: 0.13.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.4.0-preview1 version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.4.0-preview2 /build-all-ruby/3.4.0-preview2/lib/ruby/3.4.0+0/uri/common.rb:53:in 'URI.const_missing': uninitialized constant URI::PATTERN (NameError)
from -e:1:in '<main>'
exit 1
/usr/bin/ruby version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
Reacted by Alex Counsell
Reacted by Hiroshi SHIBATA
Metadata
Metadata
Assignees
Labels
No labels
Activity
jrafanie commentedon Nov 7, 2024
Looking at the diff from 0.13.1 to 1.0.0, I don't see this warning even with -W2 or --verbose.
v0.13.1...v1.0.0#diff-936b286152b1184cde04f027289d65e633d0f3ee52fdc42cf4eb072c24312e15R48-R54
jrafanie commentedon Nov 7, 2024
Please let me know why I'm not receiving the warning and what we should be using instead of URI::PATTERN. Should we be using
URI::RFC2396_REGEXP::PATTERN?jrafanie commentedon Nov 7, 2024
I see that URI::REGEXP was also removed without a deprecation warning.
This worked in many prior rubies.
firecall commentedon Nov 8, 2024
Can confirm the above, receiving same:
NameError: uninitialized constant URI::REGEXP (NameError)[ruby/uri] Added more fallback constants like URI::PARTTERN and URI::…
hsbt commentedon Nov 8, 2024
Thank you for reporting this.
I fixed at 1f3d3df. And released 1.0.1 with that fix.
jrafanie commentedon Nov 8, 2024
Thank you @hsbt! Using 1.0.1, with warnings enabled, I'm now seeing the warnings for these two constants but it continues to work as it did in earlier versions. Looks good to me. Thank you for the quick response!
Added more fallback constants like URI::PARTTERN and URI::REGEXP