Skip to content

Handle superclass with identical name #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mame merged 1 commit into from
May 24, 2024
Merged

Handle superclass with identical name #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/typeprof/import.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,14 @@ def import(explicit = false)
members = cdef[:members]

name = classpath.last
superclass = path_to_klass(superclass) if superclass
if superclass
if superclass == classpath
# Remove the second to last element so that lookup happens in the parent
superclass = superclass.dup
superclass.delete_at(-2)
end
superclass = path_to_klass(superclass)
end
base_klass = path_to_klass(classpath[0..-2])

klass, = @scratch.get_constant(base_klass, name)
Expand Down
4 changes: 4 additions & 0 deletions smoke/rbs-matching-superclass.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
class Foo
end
__END__
# Classes
7 changes: 7 additions & 0 deletions smoke/rbs-matching-superclass.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class Foo
end

class Bar
class Foo < Foo

@wagenet wagenet Dec 21, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, this would look for Bar::Foo instead of ::Foo.

end
end