Do not kill the Ruby process when IDE debugger session disconnects #199

Activity

1. lalunamel commented on Sep 16, 2020

   

   lalunamel

   on Sep 16, 2020

   More actions

   I'd like this feature as well.

   I'm not a maintainer or anything, but I've been noodling around the code recently and can point you in the right direction.

   Here's the bit of code that handles the quit command, which is sent when your IDE disconnects from a debugging session. https://github.com/ruby-debug/ruby-debug-ide/blob/master/lib/ruby-debug-ide/commands/control.rb#L2

   Commands are sent over a socket from the IDE to ruby-debug-ide and parsed here. https://github.com/ruby-debug/ruby-debug-ide/blob/master/lib/ruby-debug-ide/ide_processor.rb#L75

   I'd imagine any solution to prevent ruby-debug-ide from terminating would involve mucking around in control.rb

   🚀React with 🚀1Reacted by Mark Allen
2. hurricup commented on Sep 17, 2020

   

   hurricup

   on Sep 17, 2020

   Contributor

   More actions

   @TSMMark what version of the gem used?
3. TSMMark commented on Sep 17, 2020

   

   TSMMark

   on Sep 17, 2020

   Author

   More actions

   @hurricup latest. ruby-debug-ide (0.7.2)
4. TSMMark commented on Sep 25, 2020

   

   TSMMark

   on Sep 25, 2020

   Last edited by TSMMark

   Author

   More actions

   In my quick local testing, it looks like simply removing the exit! line here works like a charm!

   ruby-debug-ide/lib/ruby-debug-ide/commands/control.rb

   Line 14 in 83b5d22

   exit! # exit -> exit!: No graceful way to stop threads...

   The same Ruby process can later be reattached to the debugger and everything.

   ---

   I'll try to submit a PR asap that optionally skips the exit! based on cli flag or env var or something
5. yasaichi commented on Sep 10, 2022

   

   yasaichi

   on Sep 10, 2022

   Last edited by yasaichi

   More actions

   For the future googlers, here's my patch until the PR is merged:

   $ cat bin/rdebug-ide
   #!/usr/bin/env ruby
   require "rubygems"
   require "bundler/setup"
   require "ruby-debug-ide"
   
   Debugger::QuitCommand.prepend(
     Module.new {
       def execute
         # NOTE: We must ensure that all breakpoints are cleared before disconnecting sessions,
         # or you'll face a `closed stream` error.
         Debugger.breakpoints.clear
         @printer.print_msg("finished")
       end
     }
   )
   
   load Gem.bin_path("ruby-debug-ide", "rdebug-ide")

   Usage:

   $ bin/rdebug-ide [same arguments as the original ones]
6. instructure-gerrit

   added a commit that references this issue on Nov 7, 2022

   Don't terminate web container when disconnecting debugger

   ...

   03ffd9d