Repository navigation
Close async TCP sockets when connection setup is interrupted - #51
Merged
romis2012 merged 1 commit intoOct 31, 2026
Merged
Conversation
Signed-off-by: Mayank Dhingra <mayankdhingra02@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 94.36% 94.31% -0.05%
==========================================
Files 55 55
Lines 1562 1566 +4
==========================================
+ Hits 1474 1477 +3
- Misses 88 89 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancellation or a timeout while establishing an asyncio/Trio TCP connection bypasses the existing
OSErrorcleanup, leaving the newly allocated socket open. A failed local-address bind has the same ownership gap.Keep socket setup, binding and connection establishment inside the cleanup guard, close on any unsuccessful exit, and re-raise the original exception. Successfully returned sockets remain open for the caller. The stream-based v2 and AnyIO helpers are unchanged.
Validation on macOS:
Proxy.connect()task cancellation, without socket/loop mocks, leaves an open descriptor on the original code and a closed descriptor with the fix.Linux and Windows remain for CI.