Repository navigation
upstreaming: reconcile controller events from current main - #4977
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly check out current
mainin both controller jobs instead of the trigger event SHA.Multiple completion events can queue controller runs with different historical
github.shavalues. Using those event SHAs lets a later serialized reconciliation plan an operation against state from before an earlier controller commit, producing duplicate launches of the same deterministic operation.With
ref: main, the serialized job sees the latest committed operation and suppresses another request.Live failure addressed
Development PR #1 received three CI runs: its initial
openedevent and tworeopenedevents. The samedev_pr_updateoperation was dispatched twice by controller runs that had checked out stale event SHAs. Both effect workflows were idempotent, but each reopen emitted another CI run.Validation
ref: mainwith persisted credentials disabled.