Skip to content

upstreaming: reconcile controller events from current main - #4977

Merged
luhenry merged 2 commits into
mainfrom
upstreaming-pipeline
Nov 20, 2026
Merged

luhenry merged 2 commits into
mainfrom
upstreaming-pipeline

Conversation

@luhenry

@luhenry luhenry commented Nov 20, 2026

Copy link
Copy Markdown
Member

Summary

Explicitly check out current main in both controller jobs instead of the trigger event SHA.

Multiple completion events can queue controller runs with different historical github.sha values. Using those event SHAs lets a later serialized reconciliation plan an operation against state from before an earlier controller commit, producing duplicate launches of the same deterministic operation.

With ref: main, the serialized job sees the latest committed operation and suppresses another request.

Live failure addressed

Development PR #1 received three CI runs: its initial opened event and two reopened events. The same dev_pr_update operation was dispatched twice by controller runs that had checked out stale event SHAs. Both effect workflows were idempotent, but each reopen emitted another CI run.

Validation

  • 179 tests pass.
  • Contract tests require both observe and reconcile checkout steps to use ref: main with persisted credentials disabled.
  • actionlint and state-only trigger checks pass.

@luhenry
luhenry merged commit c3e95fe into main Nov 20, 2026
4 checks passed
@luhenry
luhenry deleted the upstreaming-pipeline branch November 20, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant