Skip to content

upstreaming: register safe fork CI and forbid unrelated debug changes - #4961

Merged
luhenry merged 2 commits into
mainfrom
upstreaming-pipeline
Nov 19, 2026
Merged

luhenry merged 2 commits into
mainfrom
upstreaming-pipeline

Conversation

@luhenry

@luhenry luhenry commented Nov 19, 2026

Copy link
Copy Markdown
Member

Summary

  • When a fresh fork contains workflow files but GitHub reports no registered Actions workflows, reapply the repository Actions switch with the one-fork Administration token and require registration before continuing.
  • Then explicitly enable safe CI and disable privileged/publication workflows using the authoritative default-branch contents inventory.
  • Strengthen patch-worker instructions from live review feedback:
    • do not add push: riscv64 when an existing pull_request trigger covers the development PR base;
    • never broaden inputs.upload, add github.event_name == 'push', or alter unrelated event, artifact-retention or release behavior for fork validation;
    • leave intentional PR artifact policy unchanged and record the acceptance limitation for a separate trusted probe;
    • before any edit, extensively inspect per-file commit history, blame, relevant accepted/rejected PRs, issues, reviews and contribution/release policy;
    • edit changelogs or similar policy-sensitive files only when that evidence establishes the convention.

Live evidence

Development PR #1 has the correct riscv64 matrix changes, but its debug commit also added an unnecessary push trigger and broadened artifact upload behavior. The base workflow already has pull_request for master, so these changes are unrelated and must be removed.

No CI ran because the fresh fork has three workflow files but its Actions API inventory is empty. A prior enable-by-filename attempt returned 404 because workflows were not registered. The existing marked PR operation remains retriable; after registration and safe enablement, the workflow reopens that exact PR once to emit the standard event.

Validation

  • 169 tests pass.
  • Tests cover fresh-fork registration, safe enablement, unsafe disabling, exact marked-PR reuse and the strengthened worker contract.
  • All three gh-aw v1.2.2 workflows compile and generated locks match.

@luhenry
luhenry merged commit 45e5495 into main Nov 19, 2026
4 checks passed
@luhenry
luhenry deleted the upstreaming-pipeline branch November 19, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant