Repository navigation
Conversation
…ler block c4657ad declared ResultAsRegister in the interface section, but its implementation stayed inside the {$else} branch of {$ifdef empty_methods_handler}. On every target where that symbol is defined (FPC on cpu64, cpuarm and cpupowerpc; Delphi on cpuarm and cpuarm64) the unit no longer compiles: uPSRuntime.pas(892) Error: E2065 Unsatisfied forward or external declaration: 'ResultAsRegister' The function does not depend on the handler, so it is moved unchanged in front of the block. Reproduced with Delphi 13 by compiling uPSRuntime with -Dcpuarm64 on Win64, which takes the empty_methods_handler path; with the change it compiles there, and plain Win64 and Win32 builds are unaffected.
Contributor
Author
|
Duplicate of #313, which makes the same move of ResultAsRegister, also covers Inc/Dec on Variant and was verified on FPC. Closing in favour of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
c4657ad declared
ResultAsRegisterin the interface section ofuPSRuntime, but its implementation stayed inside the{$else}branch of{$ifdef empty_methods_handler}. On every target whereempty_methods_handleris defined, the unit no longer compiles:empty_methods_handleris defined by uPSRuntime itself for FPC oncpu64,cpuarmandcpupowerpc, and for Delphi oncpuarmandcpuarm64.Change
ResultAsRegisterdoes not depend on the method handler, so it is moved unchanged in front of the{$ifdef empty_methods_handler}block. No other change.Testing
Delphi 13, a minimal program that uses
uPSRuntime,uPSCompileranduPSUtils:-Dcpuarm64(takes theempty_methods_handlerpath): E2065 before, compiles after.I have no FPC installation at hand, so the FPC
cpu64case is inferred from the same{$ifdef}structure, not compiled.