Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the feedback-submission error-handling fix.
No open issues 🎉
What changed in this PR
This PR fixes failed Send handling in the browser SDK’s manual and automated feedback forms, keeping HTTP-error handling separate from the close-lifecycle work in #798.
Changes:
- Reject unsuccessful submissions before invoking
onAfterSubmit, allowing the existing form error handler to display an error and support retry. - Add regression tests for both feedback sources covering a 500 response followed by a successful retry.
- Add a patch changeset for the browser SDK.
| File | Description |
|---|---|
packages/browser-sdk/test/feedbackSubmitErrors.test.ts |
Tests failed submissions and successful retries for both feedback sources. |
packages/browser-sdk/src/feedback/feedback.ts |
Rejects automated submissions when no feedback ID is returned. |
packages/browser-sdk/src/client.ts |
Rejects manual submissions when the response is unsuccessful. |
.changeset/quiet-feedback-errors.md |
Documents the fix in a browser SDK patch changeset. |
Review effort: Balanced
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split the adjacent HTTP-error fix out of #798 so the callback-on-close feature stays focused. This PR is based directly on
main.onAfterSubmitwith unsaved data.Verification
The declaration plugin emits the same previously verified baseline MSW
HttpResponsetest-type diagnostics; no new diagnostics were introduced.