Repository navigation
Update appwrite to 28.4.0 and track push events - #27
Open
lohanidamodar wants to merge 1 commit into
Open
lohanidamodar wants to merge 1 commit into
lohanidamodar wants to merge 1 commit into
Conversation
Bump appwrite from 28.4.0-rc.1 to ^28.4.0. Nothing breaks: the release adds to rc.1 and the Android plugin stops declaring the foreground service permissions, which the manifest already removes. The app was not reporting push analytics. Android (Appwrite Push) now passes a Tracking to Push.setTracking, so the SDK sends push_received and push_opened with the messageId and deduplicates them. iOS (APNs via the push plugin) sends the same events from its foreground and tap handlers. Both go through AnalyticsService, so the user's analytics opt-out still applies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appwritefrom28.4.0-rc.1to^28.4.0. I read the changelog from rc.1 to 28.4.0 and nothing breaks. The one Android change is that the plugin no longer declaresFOREGROUND_SERVICE/FOREGROUND_SERVICE_REMOTE_MESSAGING. Our manifest already removes both, and the merged debug manifest has neither.AnalyticsServicegetspushReceived/pushOpened, and both go throughConsentedAnalytics, so the opt-out still applies.SdkLivePushcallsPush.setTrackingwith aPushTracking, a smallTrackingsubclass that hands the SDK's push hooks toAnalyticsService. The SDK sendspush_received(non-interactive) andpush_openedwith themessageIdand removes duplicates.pushplugin):push_receivedfires when a notification arrives in the foreground, andpush_openedfires on taps (launch tap, later taps, local-notification taps). ThemessageIdis included when the payload has one.Tracking.start(), which sends lifecycle events plusfirst_open/app_updated, and the screen-viewNavigatorObserveralready match the 28.4.0 API, so they are unchanged.Test plan
flutter analyze: no issues on Flutter 3.47.8, the same minor as CI's 3.47.1flutter test: 83 passed, including new tests for push events and consent gatingflutter build apk --debug(Flutter 3.47.8)