Repository navigation
[CodingStyle] Import plain partially qualified names again, keep Doctrine/Symfony aliases covered - #8933
Merged
Conversation
…rine/Symfony aliases covered Revert the partially qualified name guard from #8932: a node copied from another file keeps its partially qualified originalName and was left fully qualified instead of imported. Aliased names like ORM\Column and Assert\Length are already kept, so keep regression fixtures for them using the Doctrine and Symfony stubs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8932.
#8932 kept every partially qualified name as written. That caused a regression: a node copied from another file (e.g. an inherited constructor param typed
Sub\Depin the parent file) keeps its partially qualifiedoriginalName, so it stayed fully qualified in the child instead of being imported.This PR:
ClassNameImportSkipperand restores the 10 fixtures, so plain partially qualified names (use App\Field; Field\TextField) are imported again, as before [CodingStyle] Keep partially qualified names as written on import names #8932.The fixtures cover attributes, annotations,
@var,new,::class, param/return types, and an alias used next to a direct import of the same class.