Repository navigation
[PHPUnit60] Change AddDoesNotPerformAssertionToNonAssertingTestRector node from ClassMethod to Class_ - #830
Merged
Conversation
TomasVotruba
force-pushed
the
does-not-perform-assertion-on-class
branch
from
November 14, 2026 17:23
ede393c to
c11dd51
Compare
Member
Author
|
By convention, PHPUnit test-related Rector rules that need to have context of both class method and class, should always hook into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule now visits
Class_and walks its methods, keeping the same name.Scopeclass reflection), asserting lifecycle methodsresolveCurrentClass()lookup in file stmts is gone, the lifecycle check gets theClass_directlyClass_nodesClass_nodesPHPUnit10DataProviderfixture changed, as this rule now runs before the method-levelDataProviderAnnotationToAttributeRector