Error when running rename-unsafe-lifecycles

Seeing this error when running rename-unsafe-lifecycles:

Error: did not recognize object of type "ImportExpression"
    at Object.getFieldNames (/Users/wes/.npm/_npx/76919/lib/node_modules/react-codemod/node_modules/ast-types/lib/types.js:701:19)
    at getSortedChildNodes (/Users/wes/.npm/_npx/76919/lib/node_modules/react-codemod/node_modules/recast/lib/comments.js:50:23)
    at getSortedChildNodes (/Users/wes/.npm/_npx/76919/lib/node_modules/react-codemod/node_modules/recast/lib/comments.js:63:9)
    at decorateComment (/Users/wes/.npm/_npx/76919/lib/node_modules/react-codemod/node_modules/recast/lib/comments.js:73:22)
    at decorateComment (/Users/wes/.npm/_npx/76919/lib/node_modules/react-codemod/node_modules/recast/lib/comments.js:84:13)
    at decorateComment (/Users/wes/.npm/_npx/76919/lib/node_modules/react-codemod/node_modules/recast/lib/comments.js:84:13)
    at decorateComment (/Users/wes/.npm/_npx/76919/lib/node_modules/react-codemod/node_modules/recast/lib/comments.js:84:13)
    at decorateComment (/Users/wes/.npm/_npx/76919/lib/node_modules/react-codemod/node_modules/recast/lib/comments.js:84:13)
    at /Users/wes/.npm/_npx/76919/lib/node_modules/react-codemod/node_modules/recast/lib/comments.js:129:9
    at Array.forEach (<anonymous>)```

Could you try to isolate what file this happened on? If you could make a git repo with a reduced usecase, that would be excellent.

Just to be sure that it isn’t related to your own dependencies, would you also try running this from outside your project? ie- instead of cd my-project and npx react-codemod ..., could you run `npx react-codemod my-project‘?

Ahh it seems to not like React.lazy

@threepointone

@threepointone https://github.com/wesleyyee/codeshift-react-lazy

Very helpful, thank you! I'll have a look this weekend.

@threepointone

@threepointone Did you ever solve this? I have a similar problem in a codemod I am writing where it chokes on the dynamic import.

Not using React.lazy, but same syntax with loadable:

const Dooby = loadable(
  () => import('dooby/doo'),
  {
    fallback: <LoadingPage />
  }
);

I'm not doing any active development on this, but I'd be happy to review and land a PR with a fix.

Hey, not sure if related, but also getting a similar error Error: did not recognize object of type "ChainExpression" with the same stack trace when running rename-unsafe-lifecycles

@sterlu

@sterlu I had the same ChainExpression error when running over our large non-TS codebase - it seems to choke on optional chaining operators ?..

By telling the codemod to treat the code as Typescript it worked though.

try npx react-codemod rename-unsafe-lifecycles it'll work

Navigation Menu

Repository navigation

Error when running rename-unsafe-lifecycles #254

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Error when running rename-unsafe-lifecycles #254

Description

Activity

threepointone commented on Feb 12, 2020

wesleyyee commented on Feb 13, 2020

wesleyyee commented on Feb 14, 2020

threepointone commented on Feb 18, 2020

Jayphen commented on May 15, 2020

threepointone commented on Jul 7, 2020

sterlu commented on Aug 24, 2020

rbalmf commented on Oct 11, 2020

parthakshay commented on Apr 14, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions