Skip to content

Fix Flaky Tests #759

Description

@rmorshea

Current Situation

There are a number of tests in the suite that are very flaky (usually requiring 2-3 runs to pass). For new contributors this is likely to be confusing since they'll be unsure if those failures are related to their changes. Unfortunately the problems are hard to reproduce since running the local tests rarely, if ever, fails at the rate seen in CI/CD. I've also noticed that there are times when the CI/CD will pass on the first go, while on others it will simply refuse to pass.

Proposed Actions

It's likely that these flaky tests are missing some sort of locking mechanism to ensure that actions occur in the correct order (or at least that's been my experience in the past).

Activity

  1. added this to the milestone on Jun 13, 2022
  2. removed this from the milestone on Feb 21, 2023
  3. Archmonger commented on Jan 25, 2025

    @Archmonger
    Contributor

    Resolved in #1251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flag-good-first-issueA well defined and self-contained task.priority-2-moderateShould be resolved on a reasonable timeline.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions