Skip to content

Support dot notation in reactpy.web.export #543

Closed
Feature
#1285
Closed
Support dot notation in reactpy.web.export#543
Feature
#1285
Labels
flag-good-first-issueA well defined and self-contained task.priority-3-lowMay be resolved one any timeline.

Description

@Archmonger
Archmonger
opened on Dec 11, 2021

Current Situation

Currently nested imports cannot be resolved, such as Bootstrap Navbar.Toggle

bootstrap = reactpy.web.module_from_template(
    "react", "react-bootstrap", resolve_exports=True
)
toggler = reactpy.web.export(bootstrap, "Navbar.Toggle")

Proposed Changes

Update reactpy.web.export to support dot notation by modifying this check to drill down into the module using the dot-separate names rather than just checking to see if it's a direct export. Here's how this could be done.

For more information see this comment.

Activity

  1. Archmonger
    added
    flag-triageNot prioritized.
    on Dec 11, 2021
  2. rmorshea
    added
    enhancement
    and removed
    flag-triageNot prioritized.
    on Jan 9, 2022
  3. rmorshea
    added this to the 1.0 milestone on Jan 11, 2022
  4. rmorshea
    added
    priority-2-moderateShould be resolved on a reasonable timeline.
    on Jan 13, 2022
  5. rmorshea
    added
    flag-good-first-issueA well defined and self-contained task.
    on Feb 9, 2022

  6. rmorshea commented on Nov 29, 2022

    @rmorshea
    rmorshea
    on Nov 29, 2022
    Collaborator

    Gonna push this to 2.0 since it's more of a nicety.

  7. rmorshea
    added
    priority-3-lowMay be resolved one any timeline.
    and removed
    priority-2-moderateShould be resolved on a reasonable timeline.
    on Nov 29, 2022
  8. rmorshea
    modified the milestones: 1.0, on Nov 29, 2022
  9. Archmonger
    modified the milestones: , on Jan 29, 2023
  10. rmorshea
    removed this from the milestone on Feb 21, 2023
  11. Archmonger
    changed the title [-]Support dot notation in idom.web.export[/-] [+]Support dot notation in reactpy.web.export[/+] on Jan 26, 2025
  12. Archmonger
    removed
    type-feature
    on Feb 12, 2025
  13. Archmonger
    linked a pull request that will close this issueSubcomponent notation #1285on Mar 18, 2025
  14. Archmonger
    closed this as completedon Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flag-good-first-issueA well defined and self-contained task.priority-3-lowMay be resolved one any timeline.

    Type

    Feature

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions