Repository navigation
Conversation
This was referenced Nov 10, 2026
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Expo
huntie
requested review from
cipolleschi,
cortinico,
robhogan and
rubennorte
November 10, 2026 16:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #59896
build_js_typesis currently failing on main. This is due to generated types emitting a feature that isn't supported in in TypeScript (TS1016 "A required parameter cannot follow an optional parameter.").Fix: Relocate this default inside the function instead.
Changelog: [Internal]
Test Plan
✅ On main,
test-generated-typescriptfails with TS1016 inAbortSignal.d.ts, asbuild_js_typesdoes in CI. With this change it passes, and theReactNativeApi.d.tssnapshot is unchanged.✅ Flow, ESLint and Prettier clean.
Not run:
AbortController-itest.js(Fantom).