Skip to content

Fix build_js_types: move abortSignal's required param first #59910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubennorte wants to merge 1 commit into from
Closed

Fix build_js_types: move abortSignal's required param first #59910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/src/private/webapis/dom/abort-api/AbortController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export class AbortController {
* Abort and signal to any observers that the associated activity is to be aborted.
*/
abort(reason: unknown): void {
require('./AbortSignal').abortSignal(reason, getSignal(this));
require('./AbortSignal').abortSignal(getSignal(this), reason);
}
}

Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/src/private/webapis/dom/abort-api/AbortSignal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export class AbortSignal extends EventTarget {
*/
static abort(reason: unknown): AbortSignal {
const signal = createAbortSignal();
abortSignal(reason, signal);
abortSignal(signal, reason);
return signal;
}

Expand Down Expand Up @@ -186,11 +186,11 @@ export function createAbortSignal(): AbortSignal {
* Abort a given signal.
*/
export function abortSignal(
signal: AbortSignal,
reason: unknown | void = new DOMException(
'signal is aborted without reason',
'AbortError',
),
signal: AbortSignal,
): void {
// $FlowExpectedError[invalid-compare]
// $FlowExpectedError[prop-missing]
Expand Down
Loading