Keep Fantom CI snapshot baselines read-only (#59895) by rubennorte · Pull Request #59895 · react/react-native

rubennorte · 2026-11-09T16:44:43Z

Summary:

Run Fantom with Jest's CI mode on every attempt so failed snapshot comparisons cannot rewrite their expected baselines. Retain retries for transient failures, but compare against the same committed snapshots each time.

Also enforce the existing snapshot writer's explicit-update guard at this point in the stack, so neither CI mode nor the default update mode can overwrite an existing mismatch.

Use real Jest SnapshotState instances to verify existing/missing baselines and explicit updates.

Changelog: [Internal] Prevent snapshot updates during Fantom CI runs.

Reviewed By: zeyap

Differential Revision: D130682365

meta-codesync · 2026-11-09T16:44:57Z

@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D130682365.

Summary: Run Fantom with Jest's CI mode on every attempt so failed snapshot comparisons cannot rewrite their expected baselines. Retain retries for transient failures, but compare against the same committed snapshots each time. Also enforce the existing snapshot writer's explicit-update guard at this point in the stack, so neither CI mode nor the default update mode can overwrite an existing mismatch. Use real Jest SnapshotState instances to verify existing/missing baselines and explicit updates. Changelog: [Internal] Prevent snapshot updates during Fantom CI runs. Differential Revision: D130682365

Summary: Pull Request resolved: react#59895 Run Fantom with Jest's CI mode on every attempt so failed snapshot comparisons cannot rewrite their expected baselines. Retain retries for transient failures, but compare against the same committed snapshots each time. Also enforce the existing snapshot writer's explicit-update guard at this point in the stack, so neither CI mode nor the default update mode can overwrite an existing mismatch. Use real Jest SnapshotState instances to verify existing/missing baselines and explicit updates. Changelog: [Internal] Prevent snapshot updates during Fantom CI runs. Differential Revision: D130682365

Summary: Pull Request resolved: react#59895 Run Fantom with Jest's CI mode on every attempt so failed snapshot comparisons cannot rewrite their expected baselines. Retain retries for transient failures, but compare against the same committed snapshots each time. Also enforce the existing snapshot writer's explicit-update guard at this point in the stack, so neither CI mode nor the default update mode can overwrite an existing mismatch. Use real Jest SnapshotState instances to verify existing/missing baselines and explicit updates. Changelog: [Internal] Prevent snapshot updates during Fantom CI runs. Reviewed By: zeyap Differential Revision: D130682365

Summary: Update the inspector, header and footer snapshots to reflect the current safe-area wrappers. The previous baselines describe the old structure, causing the same snapshot mismatches on repeated runs. Correct the three-log header fixture and verify previous/next navigation, rather than duplicating the single-log case. Changelog: [Internal] Update LogBox rendering tests. Reviewed By: cortinico Differential Revision: D130672828

Summary: Run Fantom with Jest's CI mode on every attempt so failed snapshot comparisons cannot rewrite their expected baselines. Retain retries for transient failures, but compare against the same committed snapshots each time. Also enforce the existing snapshot writer's explicit-update guard at this point in the stack, so neither CI mode nor the default update mode can overwrite an existing mismatch. Use real Jest SnapshotState instances to verify existing/missing baselines and explicit updates. Changelog: [Internal] Prevent snapshot updates during Fantom CI runs. Reviewed By: zeyap Differential Revision: D130682365

Summary: Pull Request resolved: react#59895 Run Fantom with Jest's CI mode on every attempt so failed snapshot comparisons cannot rewrite their expected baselines. Retain retries for transient failures, but compare against the same committed snapshots each time. Also enforce the existing snapshot writer's explicit-update guard at this point in the stack, so neither CI mode nor the default update mode can overwrite an existing mismatch. Use real Jest SnapshotState instances to verify existing/missing baselines and explicit updates. Changelog: [Internal] Prevent snapshot updates during Fantom CI runs. Reviewed By: zeyap Differential Revision: D130682365

react-native-bot · 2026-11-10T12:45:31Z

This pull request was successfully merged by @rubennorte in b13546b

^{When will my fix make it into a release? | How to file a pick request?}

## Summary: react#59797 added `experimental_onSafeAreaInsetsChange` to the root `logbox_inspector` view, and react#59893 refreshed the LogBox snapshots without that change, so both landed but the committed `LogBoxInspector` baseline is missing the prop. The two inspector snapshot tests fail in Fantom CI mode, which no longer rewrites mismatched baselines (react#59895). Regenerate the two affected snapshots; the only change is the added prop on the root view. ## Changelog: [Internal] ## Test Plan: - `CI=true yarn fantom packages/react-native/Libraries/LogBox`: 2 snapshot failures before; 90/90 tests and 54/54 snapshots pass after, on two consecutive runs. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

…59911) * Force native EventTarget event dispatching on for the React renderer ## Summary: #59896 removed `enableNativeEventTargetEventDispatching` from `ReactNativeFeatureFlags`, but the vendored Fabric renderer still reads it through `react-native/react-private-interface` to choose between `dispatchNativeEvent` and the legacy plugin-based dispatch. With the getter gone, the renderer saw `undefined`, treated the flag as off, and fell back to the legacy path, so listeners registered with `addEventListener` were never called. The `ReactNativeFeatureFlags` getter in the private interface now returns the real flags plus `enableNativeEventTargetEventDispatching: () => true`, so only the renderer sees it. This can be removed once the renderer is synced from a React build that no longer reads the flag. ## Changelog: [Internal] ## Test Plan: - `yarn fantom packages/react-native/src/private/renderer/core/__tests__/EventTargetDispatching-itest.js`: 16 failures before, 78 passed / 20 skipped after. - `yarn fantom packages/react-native/src/private/webapis/dom packages/react-native/src/private/renderer`: 513 passed, 26 skipped. - `yarn eslint --max-warnings 0` and `yarn prettier --check` on both changed files pass. - `yarn flow-check` reports only 2 unrelated parse errors from local git ref logs under `.git/logs/refs/remotes/` whose names end in `.json`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) * Fix build_js_types: move abortSignal's required param first Summary: #59896 made `ReactNativeElement` unconditionally extend `EventTarget`, which imports the `AbortSignal` type, pulling `AbortSignal.d.ts` into the generated types checked by `yarn test-generated-typescript`. The internal `abortSignal(reason = ..., signal)` helper declares a defaulted parameter before a required one, which flow-api-translator emits as `abortSignal(reason?: unknown | void, signal: AbortSignal)` and tsc rejects with TS1016. Reorder the parameters to `abortSignal(signal, reason = ...)` and update both internal callers. The public API snapshot is unchanged. Changelog: [Internal] Test Plan: - `yarn build-types --skip-snapshot && yarn test-generated-typescript`: fails with TS1016 before, passes after - `yarn build-types --validate`: API snapshot is up to date - `yarn eslint --max-warnings 0 packages/react-native/src/private/webapis/dom/abort-api/` * Update LogBoxInspector snapshots for the safe area insets listener ## Summary: #59797 added `experimental_onSafeAreaInsetsChange` to the root `logbox_inspector` view, and #59893 refreshed the LogBox snapshots without that change, so both landed but the committed `LogBoxInspector` baseline is missing the prop. The two inspector snapshot tests fail in Fantom CI mode, which no longer rewrites mismatched baselines (#59895). Regenerate the two affected snapshots; the only change is the added prop on the root view. ## Changelog: [Internal] ## Test Plan: - `CI=true yarn fantom packages/react-native/Libraries/LogBox`: 2 snapshot failures before; 90/90 tests and 54/54 snapshots pass after, on two consecutive runs. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 9, 2026

facebook-github-tools Bot added p: Facebook Partner: Facebook Partner labels Nov 9, 2026

meta-codesync Bot added the meta-exported label Nov 9, 2026

meta-codesync Bot changed the title ~~Keep Fantom CI snapshot baselines read-only~~ Keep Fantom CI snapshot baselines read-only (#59895) Nov 9, 2026

rubennorte force-pushed the export-D130682365 branch from 3fc138b to c9e40d3 Compare November 9, 2026 17:08

rubennorte added 2 commits November 10, 2026 03:39

rubennorte force-pushed the export-D130682365 branch from c9e40d3 to 1ddd615 Compare November 10, 2026 11:39

rubennorte requested review from cipolleschi, cortinico and javache November 10, 2026 11:58

cipolleschi approved these changes Nov 10, 2026

View reviewed changes

meta-codesync Bot merged commit b13546b into react:main Nov 10, 2026
84 checks passed

react-native-bot added the Merged This PR has been merged. label Nov 10, 2026

Navigation Menu

Repository navigation

Keep Fantom CI snapshot baselines read-only (#59895) - #59895

Keep Fantom CI snapshot baselines read-only (#59895)#59895
meta-codesync[bot] merged 2 commits into
react:mainfrom
rubennorte:export-D130682365

rubennorte commented Nov 9, 2026 •

edited by meta-codesync Bot

Loading

Uh oh!

meta-codesync Bot commented Nov 9, 2026

Uh oh!

Uh oh!

react-native-bot commented Nov 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rubennorte commented Nov 9, 2026 • edited by meta-codesync Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

meta-codesync Bot commented Nov 9, 2026

Uh oh!

Uh oh!

react-native-bot commented Nov 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rubennorte commented Nov 9, 2026 •

edited by meta-codesync Bot

Loading