Repository navigation
Conversation
Summary: **Problem**: The C++ spec header generated by `@react-native/codegen` declares each method's static invoker as `__<methodName>` and registers it under that name in `methodMap_`. Identifiers beginning with a double underscore are reserved to the implementation under the C++ standard ([lex.name]/3). When a library compiles with clang's `-Wreserved-identifier` and `-Werror`, it fails to compile the generated `<Module>JSI.h`. **Proposed change**: Change the invoker identifier prefix from `__` to `invoke_` in `GenerateModuleH.js` so that invokers (e.g. `invoke_<methodName>`) do not use reserved identifiers. Fixes react#59843 Changelog: [General][Fixed] - Prevent C++ TurboModule codegen from using reserved identifiers (`__<method>`) for invokers
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #59843
The C++ spec header generated by
@react-native/codegen(GenerateModuleH.js) declares each method's static invoker as__<methodName>and registers it under that name inmethodMap_. Identifiers beginning with a double underscore are reserved to the implementation under the C++ standard ([lex.name]/3). When a library compiles its sources with clang's-Wreserved-identifierand-Werror, it fails to compile the generated<Module>JSI.h.This PR renames the static invoker prefix from
__toinvoke_(e.g.invoke_<methodName>), ensuring generated headers do not declare reserved identifiers while keeping themethodMap_dispatch key, parameter types, and arity unchanged.Changelog
[General][Fixed] - Prevent C++ TurboModule codegen from using reserved identifiers (
__<method>) for invokersTest Plan
GenerateModuleH-test.js.snap).invoke_<method>instead of__<method>.