[parthrana-27]

Summary:

Fixes #59724

On Android, a FlatList (or any component using Fabric) can crash with:

java.lang.IllegalStateException: Check failed.
  at com.facebook.react.views.view.ReactViewGroup.isViewClipped(ReactViewGroup.kt:767)
  at com.facebook.react.views.view.ReactViewGroup.updateSubviewClipStatus(ReactViewGroup.kt:562)
  ...

when a View loses its native view and gets it back within the same JavaScript task — for example when a list item is unmounted and immediately remounted due to rapid state changes on a low-end Android device.

Root cause

FabricMountingManager::executeMount separates Delete mount items from the rest and writes them last as a space-efficiency optimisation. A comment in the original code acknowledged the problem:

// FIXME: this optimization is incorrect when multiple transactions are
// merged together

When two transactions are merged, the same tag can appear in a Delete mutation (from the earlier transaction) and a Create mutation (from the later transaction) inside the same merged batch. Because deletes are written last, the Java side receives a layout Update for the tag while the old native view is still attached to a different ReactViewGroup. When that view's parent is later checked in isViewClipped, check(parent === this) fails with IllegalStateException.

Fix (two parts)

1. FabricMountingManager.cpp — root cause

In the Delete mutation branch of executeMount, scan the current batch for a subsequent Create with the same tag. If one exists, promote the Delete into cppCommonMountItems so it is emitted in mutation order (before the Create), rather than being deferred to the end. For the common case where no tag is recycled in the same batch, the delete-last optimisation is fully preserved.

2. ReactViewGroup.kt — defensive guard

Replace the hard check(parent === this) in isViewClipped with a soft-exception path: when parent !== this, log a ReactNoCrashSoftException (surfaced in crash reporting) and return true (treat the view as clipped/removed). This prevents a fatal crash for any ordering edge-cases not yet covered by part 1, and is consistent with the logSoftException already present a few lines above in the same function.

Changelog:

[ANDROID] [FIXED] - Fix IllegalStateException crash in ReactViewGroup.isViewClipped when a FlatList item loses and regains its native view within a merged Fabric transaction batch

Test Plan:

Reproducer: https://github.com/Nezz/expo-repro/tree/repro/MergedTransactionDeleteOrder

1. Clone the reproducer, run npm install.
2. Build: cd android && ./gradlew assembleRelease -PreactNativeArchitectures=arm64-v8a
3. adb install -r app/build/outputs/apk/release/app-release.apk
4. Open the app and tap "one task".

Without this fix: the app crashes immediately with IllegalStateException: Check failed at ReactViewGroup.isViewClipped.

With this fix: the app no longer crashes.

Unit tests: The fix is in native C++ / Kotlin and does not change any JS or TypeScript surface. The existing ReactViewGroup unit tests pass unchanged. No new test infrastructure is required — the reproducer above is the regression test.

Static analysis: ruff/clang-format not applicable; the C++ change follows the surrounding code style and the Kotlin change matches the existing logSoftException pattern already present in isViewClipped.